Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2121953003: remove duplicate friend declaration (Closed)

Created:
4 years, 5 months ago by Mostyn Bramley-Moore
Modified:
4 years, 5 months ago
Reviewers:
dcheng, lfg
CC:
chromium-reviews, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove duplicate friend declaration This unbreaks GCC builds after https://codereview.chromium.org/2036403002 BUG=587025 TBR=lfg@chromium.org, dcheng@chromium.org Committed: https://crrev.com/1d95768c29385d7122f7a0f52b5ccbe61ac67a10 Cr-Commit-Position: refs/heads/master@{#403795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Mostyn Bramley-Moore
@lfg, dcheng: TBR'ing this simple fix...
4 years, 5 months ago (2016-07-05 15:29:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121953003/1
4 years, 5 months ago (2016-07-05 15:29:54 UTC) #4
lfg
lgtm
4 years, 5 months ago (2016-07-05 15:32:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 16:43:53 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 16:46:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d95768c29385d7122f7a0f52b5ccbe61ac67a10
Cr-Commit-Position: refs/heads/master@{#403795}

Powered by Google App Engine
This is Rietveld 408576698