Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: content/renderer/render_widget.h

Issue 2121953002: Do not calculate composition bounds until IME requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove OS_ANDROID from render_widget.cc Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index 27f71b3bc552e5e10c871e9a0b774a5ea8bfee01..2bb04db839bd712ebae9994cdffacc8666754dae 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -350,7 +350,9 @@ class CONTENT_EXPORT RenderWidget
// changed. If they are changed, the new value will be sent to the browser
// process. This method does nothing when the browser process is not able to
// handle composition range and composition character bounds.
- void UpdateCompositionInfo(bool should_update_range);
+ // If immediate_request is true, render sends the latest composition info to
+ // the browser even if the composition info is not changed.
+ void UpdateCompositionInfo(bool immediate_request);
// Change the device ICC color profile while running a layout test.
void SetDeviceColorProfileForTesting(const std::vector<char>& color_profile);
@@ -492,6 +494,10 @@ class CONTENT_EXPORT RenderWidget
void OnRequestTextInputStateUpdate();
#endif
+ // Called by the browser process to update the cursor and composition
+ // information.
+ void OnRequestCompositionUpdate(bool immediate_request, bool monitor_request);
+
// Notify the compositor about a change in viewport size. This should be
// used only with auto resize mode WebWidgets, as normal WebWidgets should
// go through OnResize.
@@ -736,6 +742,9 @@ class CONTENT_EXPORT RenderWidget
std::deque<blink::WebTextInputInfo> text_input_info_history_;
#endif
+ // True if the IME requests updated composition info.
+ bool monitor_composition_info_;
+
std::unique_ptr<RenderWidgetScreenMetricsEmulator> screen_metrics_emulator_;
// Popups may be displaced when screen metrics emulation is enabled.

Powered by Google App Engine
This is Rietveld 408576698