content/renderer/render_frame_impl.cc - Issue 2121953002: Do not calculate composition bounds until IME requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2121953002: Do not calculate composition bounds until IME requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [WIP] check with try bots Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('K') | « content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 18195893d97b57e0f05a5ad63c8bc66c324dd784..2483c70e7911d2aa66b5b6030bb46f1222c7b7b4 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -1299,7 +1299,7 @@ void RenderFrameImpl::PepperCancelComposition(

return;

Send(new InputHostMsg_ImeCancelComposition(render_view_->GetRoutingID()));

#if defined(OS_MACOSX) || defined(USE_AURA)

- GetRenderWidget()->UpdateCompositionInfo(true);

+ GetRenderWidget()->UpdateCompositionInfo(true, false /* force update */);

yosin_UTC9 2016/07/06 02:02:01 How about const bool shouldUpdateRange = true; c

Seigo Nonaka 2016/07/06 03:25:56 Done.

#endif

}