content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java - Issue 2121953002: Do not calculate composition bounds until IME requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java

Issue 2121953002: Do not calculate composition bounds until IME requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [WIP] check with try bots Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/ime_adapter_android.cc ('K') | « content/common/input_messages.h ('k') | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('j') | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java b/content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java

index 443e7d25a4c660083b3906c8b44f6f471bfc4050..cbc67452eaeb6c18e3193dc6842441b47b811a4a 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/CursorAnchorInfoController.java

@@ -137,6 +137,7 @@ final class CursorAnchorInfoController {

mLastCursorAnchorInfo = null;

mCompositionCharacterBounds = compositionCharacterBounds;

}

+ updateCursorAnchorInfo(view);

}

/**

@@ -198,14 +199,6 @@ final class CursorAnchorInfoController {

}

- /**

- * Resets the current state on update monitoring mode to the default (= do nothing.)

- */

- public void resetMonitoringState() {

- mMonitorModeEnabled = false;

- mHasPendingImmediateRequest = false;

- }

public void focusedNodeChanged(boolean isEditable) {

mIsEditable = isEditable;

mCompositionCharacterBounds = null;