[SPv2] Paint accelerated canvases as foreign layers.

[SPv2] Paint accelerated canvases as foreign layers.

WebGL demos now work with --enable-slimming-paint-v2 --enable-layer-lists.

BUG=587970
Committed: https://crrev.com/d5eafcd43984e1a5dc706f4ff772d855dda51f63
Cr-Commit-Position: refs/heads/master@{#404458}

[jbroman, 2016-07-05 22:27:22]

Patchset #1 (id:1) has been deleted

[jbroman, 2016-07-05 22:27:25]

Patchset #1 (id:20001) has been deleted

[jbroman, 2016-07-05 23:00:32]

jbroman@chromium.org changed reviewers:
+ pdr@chromium.org, trchen@chromium.org

[pdr., 2016-07-07 22:58:28]

On 2016/07/05 at 23:00:32, jbroman wrote:
> 

This also looks great. Is it easy to create a testcase similar to
VideoPainterTest?

[jbroman, 2016-07-08 15:28:23]

On 2016/07/07 at 22:58:28, pdr wrote:
> On 2016/07/05 at 23:00:32, jbroman wrote:
> > 
> 
> This also looks great. Is it easy to create a testcase similar to
VideoPainterTest?

Done. WebGL turns out to be a little annoying (there are several places that
issue commands to query for supported extensions and bail out if they don't like
what they see), but I can exercise the same code by forcing Canvas2D into
accelerated mode.

My most fun discovery here was that HTMLCanvasElement::createLayoutObject won't
give you a LayoutHTMLCanvas if JavaScript is disabled; it took me awhile to
figure that out. :)

[jbroman, 2016-07-08 15:28:58]

Patchset #2 (id:60001) has been deleted

[jbroman, 2016-07-08 17:14:49]

Patchset #2 (id:80001) has been deleted

[jbroman, 2016-07-08 17:16:59]

Patchset #2 (id:100001) has been deleted

[pdr., 2016-07-08 17:29:18]

On 2016/07/08 at 15:28:23, jbroman wrote:
> On 2016/07/07 at 22:58:28, pdr wrote:
> > On 2016/07/05 at 23:00:32, jbroman wrote:
> > > 
> > 
> > This also looks great. Is it easy to create a testcase similar to
VideoPainterTest?
> 
> Done. WebGL turns out to be a little annoying (there are several places that
issue commands to query for supported extensions and bail out if they don't like
what they see), but I can exercise the same code by forcing Canvas2D into
accelerated mode.
> 
> My most fun discovery here was that HTMLCanvasElement::createLayoutObject
won't give you a LayoutHTMLCanvas if JavaScript is disabled; it took me awhile
to figure that out. :)

Fun!

LGTM, looks fantastic.

[jbroman, 2016-07-08 17:46:01]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-07-08 17:46:01]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2121933003/#ps140001
(title: "add 'override' keyword to StubChromeClientForSPv2::didPaint")

[commit-bot: I haz the power, 2016-07-08 17:46:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 19:20:59]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2016-07-08 19:21:15]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 19:22:21]

Description was changed from

==========
[SPv2] Paint accelerated canvases as foreign layers.

WebGL demos now work with --enable-slimming-paint-v2 --enable-layer-lists.

BUG=587970
==========

to

==========
[SPv2] Paint accelerated canvases as foreign layers.

WebGL demos now work with --enable-slimming-paint-v2 --enable-layer-lists.

BUG=587970

Committed: https://crrev.com/d5eafcd43984e1a5dc706f4ff772d855dda51f63
Cr-Commit-Position: refs/heads/master@{#404458}
==========

[commit-bot: I haz the power, 2016-07-08 19:22:23]

Patchset 3 (id:??) landed as
https://crrev.com/d5eafcd43984e1a5dc706f4ff772d855dda51f63
Cr-Commit-Position: refs/heads/master@{#404458}