Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers.html

Issue 2121913002: [Typed OM] Add CSSValue -> CSSNumberValue conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sync Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers.html
diff --git a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers.html b/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers.html
index 31b1308156ad13673131b25f0ae28a750ecd0e22..cd59ebf0022f6642f2657e600808e210a67ce598 100644
--- a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers.html
+++ b/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers.html
@@ -6,15 +6,19 @@
<script>
-var gettingProperties = [
+var settingProperties = [
'animation-iteration-count',
+ 'opacity',
+];
+
+var gettingProperties = settingProperties.concat([
'column-count',
'line-height',
'opacity',
'orphans',
'widows',
'z-index'
-];
+]);
test(function() {
for (var i = 0; i < gettingProperties.length; i++) {
@@ -27,6 +31,33 @@ test(function() {
}, "Single valued CSSNumberValues can be retrieved from Inline StyleMap");
test(function() {
+ for (var i = 0; i < settingProperties.length; i++) {
+ var value = 10 * (i + 1);
+ testElement.styleMap.set(settingProperties[i], new CSSNumberValue(value));
+
+ var result = testElement.styleMap.get(settingProperties[i]);
+ assert_true(result instanceof CSSNumberValue);
+ assert_equals(result.value, value);
+
+ assert_equals(testElement.style[settingProperties[i]], "" + value);
+ }
+}, "CSSNumberValue round trips when passed in as CSSNumberValue.");
+
+test(function() {
+ var numberValues = [ new CSSNumberValue(1), new CSSNumberValue(5.5)];
+ testElement.styleMap.set('animation-iteration-count', numberValues);
+
+ var result = testElement.styleMap.getAll('animation-iteration-count');
+ assert_equals(result.length, 2);
+ assert_true(result[0] instanceof CSSNumberValue);
+ assert_true(result[1] instanceof CSSNumberValue);
+ assert_equals(result[0].value, 1);
+ assert_equals(result[1].value, 5.5);
+
+ assert_equals(testElement.style.animationIterationCount, "1, 5.5");
+}, "CSSNumberValues in a list round trip when passed in as a list of CSSNumberValues");
+
+test(function() {
testElement.style.animationIterationCount = "6.2, 9.8, 1";
var result = testElement.styleMap.getAll('animation-iteration-count');

Powered by Google App Engine
This is Rietveld 408576698