Issue 21219002: Remove PluginDelegate completely. In a followup I'll rename PepperPluginDelegateImpl to something c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21219002: Remove PluginDelegate completely. In a followup I'll rename PepperPluginDelegateImpl to something c… (Closed)

Created:
7 years, 4 months ago by jam

Modified:
7 years, 4 months ago

Reviewers:
scottmg

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove PluginDelegate completely. In a followup I'll rename PepperPluginDelegateImpl to something clearer. BUG=263054 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214354

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -461 lines)			Patch
M	content/content_renderer.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/content_tests.gypi	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/renderer/pepper/fullscreen_container.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/host_globals.cc	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	content/renderer/pepper/host_var_tracker_unittest.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
D	content/renderer/pepper/mock_plugin_delegate.h	View		1 chunk	+0 lines, -54 lines	0 comments	Download
D	content/renderer/pepper/mock_plugin_delegate.cc	View		1 chunk	+0 lines, -81 lines	0 comments	Download
M	content/renderer/pepper/pepper_broker.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_file_io_host.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	content/renderer/pepper/pepper_file_io_host.cc	View		13 chunks	+15 lines, -36 lines	0 comments	Download
M	content/renderer/pepper/pepper_graphics_2d_host.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_platform_context_3d.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.h	View		6 chunks	+57 lines, -33 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_delegate_impl.cc	View		2 chunks	+6 lines, -9 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_instance_impl.h	View		5 chunks	+7 lines, -8 lines	0 comments	Download
M	content/renderer/pepper/pepper_plugin_instance_impl.cc	View	1	12 chunks	+18 lines, -17 lines	0 comments	Download
M	content/renderer/pepper/pepper_webplugin_impl.h	View		1 chunk	+6 lines, -5 lines	0 comments	Download
M	content/renderer/pepper/pepper_webplugin_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
D	content/renderer/pepper/plugin_delegate.h	View		1 chunk	+0 lines, -155 lines	0 comments	Download
M	content/renderer/pepper/plugin_module.h	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	content/renderer/pepper/plugin_module.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/pepper/ppapi_unittest.h	View		4 chunks	+0 lines, -5 lines	0 comments	Download
M	content/renderer/pepper/ppapi_unittest.cc	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	content/renderer/pepper/ppb_broker_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/ppb_buffer_impl.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	content/renderer/pepper/ppb_file_ref_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/ppb_image_data_impl.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	content/renderer/pepper/ppb_image_data_impl.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/ppb_network_monitor_private_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/pepper/ppb_tcp_server_socket_private_impl.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	content/renderer/pepper/ppb_tcp_socket_private_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/pepper/ppb_video_decoder_impl.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	content/renderer/pepper/renderer_ppapi_host_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/pepper/renderer_ppapi_host_impl.cc	View		3 chunks	+2 lines, -5 lines	0 comments	Download
M	content/renderer/pepper/resource_helper.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/renderer/pepper/resource_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/pepper/url_request_info_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_widget_fullscreen_pepper.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm (yay!)

Expand Messages | Collapse Messages