Declare pool_ as id instead of NSAutoreleasePool.

Declare pool_ as id instead of NSAutoreleasePool.

File platform_test.h will be included from code built with Objective C
Automatic Reference Counting that forbids explicit usage of
NSAutoreleasePools. The implementation file will not be built with ARC,
so the functionality is preserved. The implementation file cannot be
built with ARC accidentally because it mentions NSAutoreleasePool.

BUG=None
TEST=None

Committed: https://crrev.com/b80a345285b49a41e6237e3b69fc5f34756308d8
Cr-Commit-Position: refs/heads/master@{#413464}

[stkhapugin, 2016-07-05 16:09:06]

Description was changed from

==========
Declare pool_ as id instead of NSAutoreleasePool.

File platform_test.h will be included from code built with Objective C
Automatic Reference Counting that forbids explicit usage of
NSAutoreleasePools. The implementation file will not be built with ARC,
so the functionality is preserved. The implementation file cannot be
built with ARC accidentally because it mentions NSAutoreleasePool.

BUG=None
TEST=None
==========

to

==========
Declare pool_ as id instead of NSAutoreleasePool.

File platform_test.h will be included from code built with Objective C
Automatic Reference Counting that forbids explicit usage of
NSAutoreleasePools. The implementation file will not be built with ARC,
so the functionality is preserved. The implementation file cannot be
built with ARC accidentally because it mentions NSAutoreleasePool.

BUG=None
TEST=None
==========

[stkhapugin, 2016-07-05 16:09:06]

stkhapugin@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[stkhapugin, 2016-07-05 16:10:51]

PTAL

[Paweł Hajdan Jr., 2016-07-06 09:50:31]

Looks like this is part of a broader effort.

Is there a tracking bug for it?

Is there more context I can read to better understand the changes?

Mostly just checking - I think code change itself looks fine.

[noyau (Ping after 24h), 2016-07-27 09:02:16]

On 2016/07/06 09:50:31, Paweł Hajdan (OOO back Aug 1) wrote:
> Looks like this is part of a broader effort.
> 
> Is there a tracking bug for it?
> 
> Is there more context I can read to better understand the changes?
> 
> Mostly just checking - I think code change itself looks fine.

Chrome iOS is moving to ARC. Having this file being able to be included from ARC
would allow use to write test cases in an ARC target.

[stkhapugin, 2016-08-22 11:42:45]

Paweł, sorry for a long time it took me to respond. Indeed, this is a part of a
broader effort, see
https://docs.google.com/a/chromium.org/document/d/1_vxH1lvr0v6utulTsvYetTmkkx...
and this PSA:
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/arc$20...
for details. 

Thank you

[Paweł Hajdan Jr., 2016-08-22 16:07:53]

LGTM

[stkhapugin, 2016-08-22 16:11:26]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2016-08-22 16:11:34]

thank you!

[commit-bot: I haz the power, 2016-08-22 16:11:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 17:24:01]

Description was changed from

==========
Declare pool_ as id instead of NSAutoreleasePool.

File platform_test.h will be included from code built with Objective C
Automatic Reference Counting that forbids explicit usage of
NSAutoreleasePools. The implementation file will not be built with ARC,
so the functionality is preserved. The implementation file cannot be
built with ARC accidentally because it mentions NSAutoreleasePool.

BUG=None
TEST=None
==========

to

==========
Declare pool_ as id instead of NSAutoreleasePool.

File platform_test.h will be included from code built with Objective C
Automatic Reference Counting that forbids explicit usage of
NSAutoreleasePools. The implementation file will not be built with ARC,
so the functionality is preserved. The implementation file cannot be
built with ARC accidentally because it mentions NSAutoreleasePool.

BUG=None
TEST=None
==========

[commit-bot: I haz the power, 2016-08-22 17:24:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-22 17:25:54]

Description was changed from

==========
Declare pool_ as id instead of NSAutoreleasePool.

File platform_test.h will be included from code built with Objective C
Automatic Reference Counting that forbids explicit usage of
NSAutoreleasePools. The implementation file will not be built with ARC,
so the functionality is preserved. The implementation file cannot be
built with ARC accidentally because it mentions NSAutoreleasePool.

BUG=None
TEST=None
==========

to

==========
Declare pool_ as id instead of NSAutoreleasePool.

File platform_test.h will be included from code built with Objective C
Automatic Reference Counting that forbids explicit usage of
NSAutoreleasePools. The implementation file will not be built with ARC,
so the functionality is preserved. The implementation file cannot be
built with ARC accidentally because it mentions NSAutoreleasePool.

BUG=None
TEST=None

Committed: https://crrev.com/b80a345285b49a41e6237e3b69fc5f34756308d8
Cr-Commit-Position: refs/heads/master@{#413464}
==========

[commit-bot: I haz the power, 2016-08-22 17:25:55]

Patchset 1 (id:??) landed as
https://crrev.com/b80a345285b49a41e6237e3b69fc5f34756308d8
Cr-Commit-Position: refs/heads/master@{#413464}