Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2121883002: 🎤 Add JinjaProcessor to jinja_template.py to be used by other scripts (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 5 months ago
Reviewers:
Peter Wen
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add JinjaProcessor to jinja_template.py to be used by other scripts Namely, I intend to use this to genererate build.gradle files. BUG=620034 Committed: https://crrev.com/16c469908fb03e82f2011128dbc485234439e911 Cr-Commit-Position: refs/heads/master@{#403809}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -50 lines) Patch
M build/android/gyp/jinja_template.py View 1 5 chunks +62 lines, -50 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121883002/1
4 years, 5 months ago (2016-07-05 01:31:43 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/98325)
4 years, 5 months ago (2016-07-05 01:45:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121883002/20001
4 years, 5 months ago (2016-07-05 13:38:48 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-05 14:39:12 UTC) #8
agrieve
On 2016/07/05 14:39:12, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 5 months ago (2016-07-05 16:10:56 UTC) #11
Peter Wen
lgtm
4 years, 5 months ago (2016-07-05 17:53:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121883002/20001
4 years, 5 months ago (2016-07-05 18:34:11 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-05 18:38:32 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 18:38:35 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 18:40:43 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/16c469908fb03e82f2011128dbc485234439e911
Cr-Commit-Position: refs/heads/master@{#403809}

Powered by Google App Engine
This is Rietveld 408576698