Fix WebRequest's EventListener::operator<

Fix WebRequest's EventListener::operator<

std::set's count() method is expected to return 0 or 1. But due
to the fact that EventListener::operator< conditionally ignored
|embedder_process_id|, the count method could return more than 1
(e.g. 2) in release builds on Windows (VC++), and fail an assertion.

This assertion failure shows that the assumption about the uniqueness
of EventListeners (while ignoring the |embedder_process_id| value) does
not hold, i.e. there may be more than one non-webview EventListeners
with the same |extension_id| and |sub_event_name|, but different
|embedder_process_id|.

To fix this, this patch removes the conditional exclusion of
|embedder_process_id| from operator< and looks up |embedder_process_id|
before searching through the set.

BUG=589735
TEST=./unit_tests --gtest_filter=ExtensionWebRequestTest.AddAndRemoveListeners

Committed: https://crrev.com/c89943b168ef2ccc51f3ec0720e552f36ec31351
Cr-Commit-Position: refs/heads/master@{#404456}

[robwu, 2016-07-05 01:32:38]

Description was changed from

==========
Add test for adding and removing webRequest listener

BUG=589735
==========

to

==========
Fix WebRequest's EventListener::operator<

std::set's count() method is expected to return 0 or 1. But due
to the fact that EventListener::operator< conditionally ignored
|embedder_process_id|, the count method could return more than 1
(e.g. 2) in release builds on Windows (VC++), and fail an assertion.

This assertion failure shows that the assumption about the uniqueness
of EventListeners (while ignoring the |embedder_process_id| value) does
not hold, i.e. there may be more than one non-webview EventListeners
with the same |extension_id| and |sub_event_name|, but different
|embedder_process_id|.

To fix this, this patch removes the conditional exclusion of
|embedder_process_id| from operator< and looks up |embedder_process_id|
before searching through the set.

BUG=589735
TEST=./unit_tests --gtest_filter=ExtensionWebRequestTest.AddAndRemoveListeners
==========

[robwu, 2016-07-05 01:32:38]

rob@robwu.nl changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-07-08 15:53:33]

lgtm

https://codereview.chromium.org/2121873002/diff/20001/extensions/browser/api/...
File extensions/browser/api/web_request/web_request_api.h (right):

https://codereview.chromium.org/2121873002/diff/20001/extensions/browser/api/...
extensions/browser/api/web_request/web_request_api.h:278: int
GetListenerCount(void* browser_context, const std::string& event_name);
nit: GetListenerCountForTest?

[robwu, 2016-07-08 17:02:27]

The CQ bit was checked by rob@robwu.nl

[robwu, 2016-07-08 17:02:27]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2121873002/#ps40001
(title: "s/GetListenerCount/GetListenerCountForTesting/")

[commit-bot: I haz the power, 2016-07-08 17:03:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 19:14:33]

Description was changed from

==========
Fix WebRequest's EventListener::operator<

std::set's count() method is expected to return 0 or 1. But due
to the fact that EventListener::operator< conditionally ignored
|embedder_process_id|, the count method could return more than 1
(e.g. 2) in release builds on Windows (VC++), and fail an assertion.

This assertion failure shows that the assumption about the uniqueness
of EventListeners (while ignoring the |embedder_process_id| value) does
not hold, i.e. there may be more than one non-webview EventListeners
with the same |extension_id| and |sub_event_name|, but different
|embedder_process_id|.

To fix this, this patch removes the conditional exclusion of
|embedder_process_id| from operator< and looks up |embedder_process_id|
before searching through the set.

BUG=589735
TEST=./unit_tests --gtest_filter=ExtensionWebRequestTest.AddAndRemoveListeners
==========

to

==========
Fix WebRequest's EventListener::operator<

std::set's count() method is expected to return 0 or 1. But due
to the fact that EventListener::operator< conditionally ignored
|embedder_process_id|, the count method could return more than 1
(e.g. 2) in release builds on Windows (VC++), and fail an assertion.

This assertion failure shows that the assumption about the uniqueness
of EventListeners (while ignoring the |embedder_process_id| value) does
not hold, i.e. there may be more than one non-webview EventListeners
with the same |extension_id| and |sub_event_name|, but different
|embedder_process_id|.

To fix this, this patch removes the conditional exclusion of
|embedder_process_id| from operator< and looks up |embedder_process_id|
before searching through the set.

BUG=589735
TEST=./unit_tests --gtest_filter=ExtensionWebRequestTest.AddAndRemoveListeners
==========

[commit-bot: I haz the power, 2016-07-08 19:14:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-08 19:14:35]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 19:15:42]

Description was changed from

==========
Fix WebRequest's EventListener::operator<

std::set's count() method is expected to return 0 or 1. But due
to the fact that EventListener::operator< conditionally ignored
|embedder_process_id|, the count method could return more than 1
(e.g. 2) in release builds on Windows (VC++), and fail an assertion.

This assertion failure shows that the assumption about the uniqueness
of EventListeners (while ignoring the |embedder_process_id| value) does
not hold, i.e. there may be more than one non-webview EventListeners
with the same |extension_id| and |sub_event_name|, but different
|embedder_process_id|.

To fix this, this patch removes the conditional exclusion of
|embedder_process_id| from operator< and looks up |embedder_process_id|
before searching through the set.

BUG=589735
TEST=./unit_tests --gtest_filter=ExtensionWebRequestTest.AddAndRemoveListeners
==========

to

==========
Fix WebRequest's EventListener::operator<

std::set's count() method is expected to return 0 or 1. But due
to the fact that EventListener::operator< conditionally ignored
|embedder_process_id|, the count method could return more than 1
(e.g. 2) in release builds on Windows (VC++), and fail an assertion.

This assertion failure shows that the assumption about the uniqueness
of EventListeners (while ignoring the |embedder_process_id| value) does
not hold, i.e. there may be more than one non-webview EventListeners
with the same |extension_id| and |sub_event_name|, but different
|embedder_process_id|.

To fix this, this patch removes the conditional exclusion of
|embedder_process_id| from operator< and looks up |embedder_process_id|
before searching through the set.

BUG=589735
TEST=./unit_tests --gtest_filter=ExtensionWebRequestTest.AddAndRemoveListeners

Committed: https://crrev.com/c89943b168ef2ccc51f3ec0720e552f36ec31351
Cr-Commit-Position: refs/heads/master@{#404456}
==========

[commit-bot: I haz the power, 2016-07-08 19:15:43]

Patchset 3 (id:??) landed as
https://crrev.com/c89943b168ef2ccc51f3ec0720e552f36ec31351
Cr-Commit-Position: refs/heads/master@{#404456}

[mmenke, 2016-09-01 21:30:44]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2299373002/ by mmenke@chromium.org.

The reason for reverting is: This may have caused https://crbug.com/641958. 
Reverting to verify.  If it did not, I'll reland next week..

[mmenke, 2016-09-01 21:50:39]

Description was changed from

==========
Fix WebRequest's EventListener::operator<

std::set's count() method is expected to return 0 or 1. But due
to the fact that EventListener::operator< conditionally ignored
|embedder_process_id|, the count method could return more than 1
(e.g. 2) in release builds on Windows (VC++), and fail an assertion.

This assertion failure shows that the assumption about the uniqueness
of EventListeners (while ignoring the |embedder_process_id| value) does
not hold, i.e. there may be more than one non-webview EventListeners
with the same |extension_id| and |sub_event_name|, but different
|embedder_process_id|.

To fix this, this patch removes the conditional exclusion of
|embedder_process_id| from operator< and looks up |embedder_process_id|
before searching through the set.

BUG=589735
TEST=./unit_tests --gtest_filter=ExtensionWebRequestTest.AddAndRemoveListeners

Committed: https://crrev.com/c89943b168ef2ccc51f3ec0720e552f36ec31351
Cr-Commit-Position: refs/heads/master@{#404456}
==========

to

==========
Fix WebRequest's EventListener::operator<

std::set's count() method is expected to return 0 or 1. But due
to the fact that EventListener::operator< conditionally ignored
|embedder_process_id|, the count method could return more than 1
(e.g. 2) in release builds on Windows (VC++), and fail an assertion.

This assertion failure shows that the assumption about the uniqueness
of EventListeners (while ignoring the |embedder_process_id| value) does
not hold, i.e. there may be more than one non-webview EventListeners
with the same |extension_id| and |sub_event_name|, but different
|embedder_process_id|.

To fix this, this patch removes the conditional exclusion of
|embedder_process_id| from operator< and looks up |embedder_process_id|
before searching through the set.

BUG=589735,643025
TEST=./unit_tests --gtest_filter=ExtensionWebRequestTest.AddAndRemoveListeners

Committed: https://crrev.com/c89943b168ef2ccc51f3ec0720e552f36ec31351
Cr-Commit-Position: refs/heads/master@{#404456}
==========

[mmenke, 2016-09-01 21:50:52]

Description was changed from

==========
Fix WebRequest's EventListener::operator<

std::set's count() method is expected to return 0 or 1. But due
to the fact that EventListener::operator< conditionally ignored
|embedder_process_id|, the count method could return more than 1
(e.g. 2) in release builds on Windows (VC++), and fail an assertion.

This assertion failure shows that the assumption about the uniqueness
of EventListeners (while ignoring the |embedder_process_id| value) does
not hold, i.e. there may be more than one non-webview EventListeners
with the same |extension_id| and |sub_event_name|, but different
|embedder_process_id|.

To fix this, this patch removes the conditional exclusion of
|embedder_process_id| from operator< and looks up |embedder_process_id|
before searching through the set.

BUG=589735,643025
TEST=./unit_tests --gtest_filter=ExtensionWebRequestTest.AddAndRemoveListeners

Committed: https://crrev.com/c89943b168ef2ccc51f3ec0720e552f36ec31351
Cr-Commit-Position: refs/heads/master@{#404456}
==========

to

==========
Fix WebRequest's EventListener::operator<

std::set's count() method is expected to return 0 or 1. But due
to the fact that EventListener::operator< conditionally ignored
|embedder_process_id|, the count method could return more than 1
(e.g. 2) in release builds on Windows (VC++), and fail an assertion.

This assertion failure shows that the assumption about the uniqueness
of EventListeners (while ignoring the |embedder_process_id| value) does
not hold, i.e. there may be more than one non-webview EventListeners
with the same |extension_id| and |sub_event_name|, but different
|embedder_process_id|.

To fix this, this patch removes the conditional exclusion of
|embedder_process_id| from operator< and looks up |embedder_process_id|
before searching through the set.

BUG=589735
TEST=./unit_tests --gtest_filter=ExtensionWebRequestTest.AddAndRemoveListeners

Committed: https://crrev.com/c89943b168ef2ccc51f3ec0720e552f36ec31351
Cr-Commit-Position: refs/heads/master@{#404456}
==========