Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Side by Side Diff: build/config/android/config.gni

Issue 2121833002: 🎢 Add a GN assert preventing android templates in non-default toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains common system config stuff for the Android build. 5 # This file contains common system config stuff for the Android build.
6 6
7 if (is_android) { 7 if (is_android) {
8 assert(rebase_path("//", root_build_dir) == "../../", 8 assert(rebase_path("//", root_build_dir) == "../../",
9 "Android output directory must be nested 2 levels within src/ (" + 9 "Android output directory must be nested 2 levels within src/ (" +
10 "e.g.: out-gn/Debug). http://crbug.com/412935") 10 "e.g.: out-gn/Debug). http://crbug.com/412935")
11 11
12 import("//build_overrides/build.gni") 12 import("//build_overrides/build.gni")
13 13
14 # Disable all java-related templates in secondary toolchains. Java is not
15 # toolchain-dependent, so a variation on toolchains is likely a mistake.
16 if (enable_java_templates) {
17 assert(current_toolchain == default_toolchain,
18 "Android templates should be used only by the default toolchain.")
19 }
20
14 has_chrome_android_internal = 21 has_chrome_android_internal =
15 exec_script("//build/dir_exists.py", 22 exec_script("//build/dir_exists.py",
16 [ rebase_path("//clank", root_build_dir) ], 23 [ rebase_path("//clank", root_build_dir) ],
17 "string") == "True" 24 "string") == "True"
18 25
19 if (has_chrome_android_internal) { 26 if (has_chrome_android_internal) {
20 import("//clank/config.gni") 27 import("//clank/config.gni")
21 } 28 }
22 29
23 if (!defined(extra_chrome_shared_library_configs)) { 30 if (!defined(extra_chrome_shared_library_configs)) {
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 } else if (current_cpu == "mips64el") { 282 } else if (current_cpu == "mips64el") {
276 android_app_abi = "mips64" 283 android_app_abi = "mips64"
277 } else { 284 } else {
278 assert(false, "Unknown Android ABI: " + current_cpu) 285 assert(false, "Unknown Android ABI: " + current_cpu)
279 } 286 }
280 287
281 if (android_libcpp_lib_dir == "") { 288 if (android_libcpp_lib_dir == "") {
282 android_libcpp_lib_dir = "${android_libcpp_root}/libs/${android_app_abi}" 289 android_libcpp_lib_dir = "${android_libcpp_root}/libs/${android_app_abi}"
283 } 290 }
284 } 291 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698