Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 212183004: Remove unneeded mutable keyword in some member variables (Closed)

Created:
6 years, 9 months ago by gyuyoung-inactive
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, pdr., Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unneeded mutable keyword in some member variables Some member variables have mutable keyword though they don't used by const function. This cl removes them. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170126

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/storage/StorageArea.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
gyuyoung-inactive
6 years, 9 months ago (2014-03-26 09:18:50 UTC) #1
kouhei (in TOK)
svg/ non-owner lgtm
6 years, 9 months ago (2014-03-26 09:22:16 UTC) #2
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 9 months ago (2014-03-26 11:46:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/212183004/30001
6 years, 9 months ago (2014-03-26 11:46:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 11:57:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-26 11:57:51 UTC) #6
gyuyoung-inactive
On 2014/03/26 11:57:51, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 9 months ago (2014-03-26 12:26:23 UTC) #7
gyuyoung-inactive
On 2014/03/26 12:26:23, gyuyoung wrote: > On 2014/03/26 11:57:51, I haz the power (commit-bot) wrote: ...
6 years, 9 months ago (2014-03-27 01:02:42 UTC) #8
gyuyoung-inactive
Add chris to reviewer as well.
6 years, 9 months ago (2014-03-27 02:54:02 UTC) #9
Inactive
lgtm
6 years, 9 months ago (2014-03-27 03:10:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/212183004/30001
6 years, 9 months ago (2014-03-27 03:10:21 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 03:21:55 UTC) #12
Message was sent while issue was closed.
Change committed as 170126

Powered by Google App Engine
This is Rietveld 408576698