Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2121793003: Stop recursion for create_bundle deps when crossing toolchain. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop recursion for create_bundle deps when crossing toolchain. Only consider the bundle_data target that are defined in the same toolchain as the create_bundle target in order to allow creation of multi-arch build using different toolchain. BUG=603180 Committed: https://crrev.com/511c073b382d6aafc6b5fd3301cfb287803e9701 Cr-Commit-Position: refs/heads/master@{#403832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/gn/target.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 5 months ago (2016-07-05 17:32:46 UTC) #2
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-05 23:51:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121793003/1
4 years, 5 months ago (2016-07-05 23:51:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 00:24:47 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 00:24:50 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 00:27:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/511c073b382d6aafc6b5fd3301cfb287803e9701
Cr-Commit-Position: refs/heads/master@{#403832}

Powered by Google App Engine
This is Rietveld 408576698