Use common_custom_types instead of remapping base::ListValue in SafeJsonParser

Use common_custom_types instead of remapping base::ListValue in SafeJsonParser

Committed: https://crrev.com/623ad061886068c1ce323e7a499b91f61918c001
Cr-Commit-Position: refs/heads/master@{#406139}

[Patrick Monette, 2016-07-04 17:44:45]

Patchset #1 (id:1) has been deleted

[Patrick Monette, 2016-07-04 17:46:12]

pmonette@chromium.org changed reviewers:
+ bauerb@chromium.org, dcheng@chromium.org

[Patrick Monette, 2016-07-04 17:46:13]

dcheng@ Security review for safe_json.mojom (no actual changes to the
interface).

[Patrick Monette, 2016-07-04 17:48:00]

pmonette@chromium.org changed reviewers:
+ jochen@chromium.org

[Patrick Monette, 2016-07-04 17:48:01]

Sent email too soon :(

bauerb@chromium.org: components/safe_json/ owner review.
jochen@chromium.org: Need review for components/typemaps.gni please

[dcheng, 2016-07-05 01:46:50]

rs lgtm for mojo changes

[Bernhard Bauer, 2016-07-05 10:32:49]

lgtm

[jochen (gone - plz use gerrit), 2016-07-05 14:19:36]

lgtm

[Patrick Monette, 2016-07-05 17:29:30]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2016-07-05 17:29:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 17:36:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 17:36:56]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Patrick Monette, 2016-07-06 18:29:11]

pmonette@chromium.org changed reviewers:
+ amistry@chromium.org

[Patrick Monette, 2016-07-06 18:29:12]

amistry@ PTAL. Need review from a Mojo owner because I added a dependency on
mojo/common.

[Anand Mistry (off Chromium), 2016-07-06 23:46:24]

lgtm

Thanks for doing this. It's been on my todo list.

[Patrick Monette, 2016-07-06 23:50:20]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2016-07-06 23:51:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 00:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 00:11:00]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patrick Monette, 2016-07-07 17:38:41]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-07-07 17:38:41]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
jochen@chromium.org, dcheng@chromium.org, amistry@chromium.org
Link to the patchset: https://codereview.chromium.org/2121793002/#ps40001
(title: "Rebase to ToT")

[commit-bot: I haz the power, 2016-07-07 17:40:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 18:41:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 18:41:20]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patrick Monette, 2016-07-11 17:51:57]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-07-11 17:51:58]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
jochen@chromium.org, dcheng@chromium.org, amistry@chromium.org
Link to the patchset: https://codereview.chromium.org/2121793002/#ps60001
(title: "export dependent settings")

[commit-bot: I haz the power, 2016-07-11 17:52:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 18:25:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 18:25:35]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Patrick Monette, 2016-07-11 20:06:55]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-07-11 20:06:55]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
jochen@chromium.org, dcheng@chromium.org, amistry@chromium.org
Link to the patchset: https://codereview.chromium.org/2121793002/#ps80001
(title: "export dependent settings")

[commit-bot: I haz the power, 2016-07-11 20:07:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 20:40:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 20:40:45]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patrick Monette, 2016-07-11 21:26:21]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-07-11 21:26:21]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
jochen@chromium.org, dcheng@chromium.org, amistry@chromium.org
Link to the patchset: https://codereview.chromium.org/2121793002/#ps100001
(title: "Mojo/common")

[commit-bot: I haz the power, 2016-07-11 21:26:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 21:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 21:33:06]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Patrick Monette, 2016-07-11 22:11:15]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-07-11 22:11:16]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
jochen@chromium.org, dcheng@chromium.org, amistry@chromium.org
Link to the patchset: https://codereview.chromium.org/2121793002/#ps120001
(title: "Public_deps")

[commit-bot: I haz the power, 2016-07-11 22:12:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 22:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-11 22:51:29]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patrick Monette, 2016-07-12 17:27:22]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-07-12 17:27:22]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
jochen@chromium.org, dcheng@chromium.org, amistry@chromium.org
Link to the patchset: https://codereview.chromium.org/2121793002/#ps140001
(title: "public deps chrome/utility")

[commit-bot: I haz the power, 2016-07-12 17:28:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:08:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:08:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patrick Monette, 2016-07-18 20:21:37]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2016-07-18 20:21:38]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
jochen@chromium.org, dcheng@chromium.org, amistry@chromium.org
Link to the patchset: https://codereview.chromium.org/2121793002/#ps180001
(title: "Fixed?")

[commit-bot: I haz the power, 2016-07-18 20:22:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 23:39:07]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2016-07-18 23:39:19]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 23:40:56]

Description was changed from

==========
Use common_custom_types instead of remapping base::ListValue in SafeJsonParser
==========

to

==========
Use common_custom_types instead of remapping base::ListValue in SafeJsonParser

Committed: https://crrev.com/623ad061886068c1ce323e7a499b91f61918c001
Cr-Commit-Position: refs/heads/master@{#406139}
==========

[commit-bot: I haz the power, 2016-07-18 23:40:57]

Patchset 9 (id:??) landed as
https://crrev.com/623ad061886068c1ce323e7a499b91f61918c001
Cr-Commit-Position: refs/heads/master@{#406139}

[alph, 2016-07-19 00:30:52]

A revert of this CL (patchset #9 id:180001) has been created in
https://codereview.chromium.org/2158003003/ by alph@chromium.org.

The reason for reverting is: Broke compilation
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20....

[Patrick Monette, 2016-07-19 17:06:01]

Description was changed from

==========
Use common_custom_types instead of remapping base::ListValue in SafeJsonParser

Committed: https://crrev.com/623ad061886068c1ce323e7a499b91f61918c001
Cr-Commit-Position: refs/heads/master@{#406139}
==========

to

==========
Use common_custom_types instead of remapping base::ListValue in SafeJsonParser

Committed: https://crrev.com/623ad061886068c1ce323e7a499b91f61918c001
Cr-Commit-Position: refs/heads/master@{#406139}
==========