Generate localizable strings in binary1 property list format.

Generate localizable strings in binary1 property list format.

Instead of converting the generated files from the old legacy format
to binary1 property list format when creating the application bundle,
directly generate them in the correct format.

BUG=625578
Committed: https://crrev.com/2e4013a84448cf8e714034e3d9d49d11cdf03227
Cr-Commit-Position: refs/heads/master@{#403679}

[sdefresne, 2016-07-04 13:24:21]

sdefresne@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[sdefresne, 2016-07-04 13:24:22]

Please take a look and send to CQ if LGTY.

[stkhapugin, 2016-07-04 13:28:40]

lgtm with comments.

https://codereview.chromium.org/2121773002/diff/1/ios/chrome/tools/strings/ge...
File ios/chrome/tools/strings/generate_localizable_strings.mm (right):

https://codereview.chromium.org/2121773002/diff/1/ios/chrome/tools/strings/ge...
ios/chrome/tools/strings/generate_localizable_strings.mm:220: error:nil];
Please add error handling. For example, print the error below (line 222).

[sdefresne, 2016-07-04 13:34:12]

Thank you for the review.

https://codereview.chromium.org/2121773002/diff/1/ios/chrome/tools/strings/ge...
File ios/chrome/tools/strings/generate_localizable_strings.mm (right):

https://codereview.chromium.org/2121773002/diff/1/ios/chrome/tools/strings/ge...
ios/chrome/tools/strings/generate_localizable_strings.mm:220: error:nil];
On 2016/07/04 13:28:40, stkhapugin wrote:
> Please add error handling. For example, print the error below (line 222).

Done.

[sdefresne, 2016-07-04 13:34:27]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-07-04 13:34:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org
Link to the patchset: https://codereview.chromium.org/2121773002/#ps20001
(title: "Display localized error.")

[commit-bot: I haz the power, 2016-07-04 13:34:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 14:15:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-04 14:15:54]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-04 14:18:20]

Description was changed from

==========
Generate localizable strings in binary1 property list format.

Instead of converting the generated files from the old legacy format
to binary1 property list format when creating the application bundle,
directly generate them in the correct format.

BUG=625578
==========

to

==========
Generate localizable strings in binary1 property list format.

Instead of converting the generated files from the old legacy format
to binary1 property list format when creating the application bundle,
directly generate them in the correct format.

BUG=625578

Committed: https://crrev.com/2e4013a84448cf8e714034e3d9d49d11cdf03227
Cr-Commit-Position: refs/heads/master@{#403679}
==========

[commit-bot: I haz the power, 2016-07-04 14:18:21]

Patchset 2 (id:??) landed as
https://crrev.com/2e4013a84448cf8e714034e3d9d49d11cdf03227
Cr-Commit-Position: refs/heads/master@{#403679}

[jif, 2016-07-05 12:08:28]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2127553002/ by jif@chromium.org.

The reason for reverting is: This breaks the iOS gyp build (gn build works
fine).
https://crbug.com/625819.