Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 2121753002: [turbofan] Robustify tail parameter stack size computations (Closed)

Created:
4 years, 5 months ago by danno
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Robustify tail parameter stack size computations This CL separates the check whether something is tail-callable from the computation of the size of the stack parameters that a function takes. In order to track this precisely, the stack parameter size calculation uses the recently landed MachineType information that's embedded in return and parameter value LinkageLocations. Committed: https://crrev.com/e92e911814cdc6d146bbd23083b8732b9881c2c5 Cr-Commit-Position: refs/heads/master@{#37668}

Patch Set 1 #

Patch Set 2 : Location should store representation #

Patch Set 3 : MachineType everywhere #

Patch Set 4 : Remove stray change #

Patch Set 5 : Remove stray changes #

Patch Set 6 : Fix windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -55 lines) Patch
M src/compiler/instruction-selector.cc View 1 2 3 4 1 chunk +4 lines, -5 lines 0 comments Download
M src/compiler/linkage.h View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/linkage.cc View 1 2 3 4 5 1 chunk +25 lines, -22 lines 0 comments Download
M test/unittests/compiler/linkage-tail-call-unittest.cc View 1 2 3 4 13 chunks +26 lines, -27 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
danno
gentle reminder :-)
4 years, 5 months ago (2016-07-11 14:46:55 UTC) #5
Benedikt Meurer
LGTM.
4 years, 5 months ago (2016-07-12 03:22:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121753002/100001
4 years, 5 months ago (2016-07-12 08:37:39 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 5 months ago (2016-07-12 08:39:38 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 08:40:56 UTC) #12
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e92e911814cdc6d146bbd23083b8732b9881c2c5
Cr-Commit-Position: refs/heads/master@{#37668}

Powered by Google App Engine
This is Rietveld 408576698