Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2121743002: Support serialization of generic methods. (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Don't serialize code with compile time errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -71 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 2 chunks +6 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/options.dart View 2 chunks +62 lines, -57 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/keys.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 4 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/type_serialization.dart View 3 chunks +8 lines, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-07-04 13:35:06 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-07-06 16:08:42 UTC) #3
Johnni Winther
4 years, 5 months ago (2016-07-08 08:03:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d650d0059b184585641eb826e31bf23d6fa3a4ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698