Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3037)

Unified Diff: build/android/buildbot/bb_host_steps.py

Issue 212173006: Don't hardcode output directory in findbugs.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-duration
Patch Set: Fixup bb_host_steps.py Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/utils/findbugs.py » ('j') | build/android/pylib/utils/findbugs.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_host_steps.py
diff --git a/build/android/buildbot/bb_host_steps.py b/build/android/buildbot/bb_host_steps.py
index b2bda6c9d682783c8d43aa0983edfd4ab78580ad..75c5661070ec65fd0625f2cc3f62c118536b09b8 100755
--- a/build/android/buildbot/bb_host_steps.py
+++ b/build/android/buildbot/bb_host_steps.py
@@ -81,13 +81,10 @@ def ExtractBuild(options):
def FindBugs(options):
bb_annotations.PrintNamedStep('findbugs')
- build_type = []
- if options.target == 'Release':
Andrew Hayden (chromium.org) 2014/03/28 08:13:25 We can't just nuke this, because we need the Relea
- build_type = ['--release-build']
- RunCmd([SrcPath('build', 'android', 'findbugs_diff.py')] + build_type)
+ RunCmd([SrcPath('build', 'android', 'findbugs_diff.py')])
RunCmd([SrcPath(
'tools', 'android', 'findbugs_plugin', 'test',
- 'run_findbugs_plugin_tests.py')] + build_type)
+ 'run_findbugs_plugin_tests.py')])
def BisectPerfRegression(options):
« no previous file with comments | « no previous file | build/android/pylib/utils/findbugs.py » ('j') | build/android/pylib/utils/findbugs.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698