Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 212173003: android: Do not pass source_dir to package_apk. (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

android: Do not pass source_dir to apk-package.xml. apkbuilder only uses sourcefolder to package non-java files (see addSourceFolder() and checkFileForPackaging() in https://android.googlesource.com/platform/sdk/+/e162064a7b5db1eecec34271bc7e2a4296181ea6/sdkmanager/libs/sdklib/src/com/android/sdklib/build/ApkBuilder.java ), and our java/src folders only contain .java (and OWNERS) files. (Determined via `find . -type f -a -path '*/src/*' -a -not -name '*.java'` and manually ignoring everything not looking like a java folder.) No intended behavior change; Chrome.apk looks identical with and without this change (except for timestamps). BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/android/ant/apk-package.xml View 2 chunks +0 lines, -4 lines 0 comments Download
M build/java_apk.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nico
6 years, 9 months ago (2014-03-27 19:57:58 UTC) #1
cjhopman
lgtm
6 years, 9 months ago (2014-03-27 20:22:17 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-27 20:24:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/212173003/1
6 years, 9 months ago (2014-03-27 20:25:26 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 00:12:39 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-28 00:12:40 UTC) #6
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-28 00:41:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/212173003/1
6 years, 9 months ago (2014-03-28 00:43:00 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 00:51:51 UTC) #9
Message was sent while issue was closed.
Change committed as 260047

Powered by Google App Engine
This is Rietveld 408576698