third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h - Issue 2121703002: Change HTMLTokenizer::Attribute::Range.start initial invalid value from 0 -> -1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

Issue 2121703002: Change HTMLTokenizer::Attribute::Range.start initial invalid value from 0 -> -1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update check Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/html/parser/HTMLToken.h » ('j') | third_party/WebKit/Source/core/html/parser/HTMLToken.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

diff --git a/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h b/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

index 3c28c83ce1d4b07d9d13f0e8b71db44161812fbb..52948efaa40fe291f699284a0fc3b879c78720b5 100644

--- a/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

+++ b/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h

@@ -235,10 +235,8 @@ inline void AtomicHTMLToken::initializeAttributes(const HTMLToken::AttributeList

if (attribute.nameAsVector().isEmpty())

continue;

- ASSERT(attribute.nameRange().start);

- ASSERT(attribute.nameRange().end);

- ASSERT(attribute.valueRange().start);

- ASSERT(attribute.valueRange().end);

+ attribute.nameRange().checkValid();

+ attribute.valueRange().checkValid();

AtomicString value(attribute.value8BitIfNecessary());

const QualifiedName& name = nameForAttribute(attribute);