Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/webdata/web_database.h

Issue 21217: Don't store empty values for autofill (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_prefs.cc ('k') | chrome/browser/webdata/web_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/webdata/web_database.h
===================================================================
--- chrome/browser/webdata/web_database.h (revision 9373)
+++ chrome/browser/webdata/web_database.h (working copy)
@@ -147,10 +147,10 @@
// Removes from autofill_dates rows with given pair_id where date_created lies
// between delte_begin and delte_end.
- bool RemovePairIDAndDate(int64 pair_id,
- const base::Time delete_begin,
- const base::Time delete_end,
- int* how_many);
+ bool RemoveFormElementForTimeRange(int64 pair_id,
+ const base::Time delete_begin,
+ const base::Time delete_end,
+ int* how_many);
// Increments the count in the row corresponding to |pair_id| by |delta|.
// Removes the row from the table if the count becomes 0.
@@ -176,7 +176,7 @@
// Adds a new row to the autofill_dates table.
bool InsertPairIDAndDate(int64 pair_id, const base::Time date_created);
- // Removes row from the autofill table given |pair_id|.
+ // Removes row from the autofill tables given |pair_id|.
bool RemoveFormElement(int64 pair_id);
//////////////////////////////////////////////////////////////////////////////
@@ -194,8 +194,14 @@
bool RemoveWebApp(const GURL& url);
private:
- friend class WebDatabaseTest;
+ FRIEND_TEST(WebDatabaseTest, Autofill);
+ // Removes empty values for autofill that were incorrectly stored in the DB
+ // (see bug http://crbug.com/6111).
+ // TODO(jcampan): http://crbug.com/7564 remove when we think all users have
+ // run this code.
+ bool ClearAutofillEmptyValueElements();
+
bool InitKeywordsTable();
bool InitLoginsTable();
bool InitAutofillTable();
« no previous file with comments | « chrome/browser/browser_prefs.cc ('k') | chrome/browser/webdata/web_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698