Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2121673002: Update dev docs to reference the new skia debugger (skiaserve) (Closed)

Created:
4 years, 5 months ago by pdr.
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update dev docs to reference the new skia debugger (skiaserve) This patch adds a new markdown file describing the new debugger along with instructions on running it locally and a sweet screenshot. The screenshot has been sized to not be clipped when viewed in production. The old documentation for the qt-based debugger has been marked as deprecated and all docs referencing the old debugger have been updated. BUG=skia:5493 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2121673002 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2121673002 Committed: https://skia.googlesource.com/skia/+/1e2a702c1959d37db734d2ecfaee0e5035b2bfbb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -113 lines) Patch
M site/dev/tools/debugger.md View 1 chunk +14 lines, -105 lines 0 comments Download
A site/dev/tools/onlinedebugger.png View Binary file 0 comments Download
A + site/dev/tools/qtdebugger.md View 1 chunk +1 line, -1 line 0 comments Download
M site/user/quick/linux.md View 1 chunk +0 lines, -2 lines 0 comments Download
M site/user/tips.md View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
pdr.
The docs_preview link has a broken image but I think that's due to how image ...
4 years, 5 months ago (2016-07-04 02:31:50 UTC) #4
mtklein
lgtm
4 years, 5 months ago (2016-07-06 13:09:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121673002/1
4 years, 5 months ago (2016-07-06 13:09:31 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 13:10:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1e2a702c1959d37db734d2ecfaee0e5035b2bfbb

Powered by Google App Engine
This is Rietveld 408576698