Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 212163006: Revert of Preserve autosizing multiplier on style recalc. (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
pdr., esprehn, skobes
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Preserve autosizing multiplier on style recalc. (https://codereview.chromium.org/208393008/) Reason for revert: This might have caused android tests failure: http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg... Speculatively reverting it. Original issue's description: > Preserve autosizing multiplier on style recalc. > > BUG=353309 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169961 TBR=pdr@chromium.org,esprehn@chromium.org,skobes@chromium.org NOTREECHECKS=true NOTRY=true BUG=353309 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170050

Patch Set 1 #

Patch Set 2 : Reverting auto-sizing three patches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -219 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +1 line, -0 lines 0 comments Download
D LayoutTests/fast/text-autosizing/font-scale-factor-change.html View 1 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/text-autosizing/font-scale-factor-change-expected.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/text-autosizing/style-recalc-no-layout.html View 1 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fast/text-autosizing/style-recalc-no-layout-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 3 chunks +0 lines, -13 lines 0 comments Download
M Source/core/page/Page.cpp View 1 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/FastTextAutosizer.h View 1 5 chunks +8 lines, -10 lines 0 comments Download
M Source/core/rendering/FastTextAutosizer.cpp View 1 10 chunks +24 lines, -79 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vsevik
Created Revert of Preserve autosizing multiplier on style recalc.
6 years, 9 months ago (2014-03-26 12:12:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/212163006/1
6 years, 9 months ago (2014-03-26 12:12:11 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 12:12:16 UTC) #3
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-26 12:12:17 UTC) #4
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-26 12:20:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/212163006/30004
6 years, 9 months ago (2014-03-26 12:20:34 UTC) #6
commit-bot: I haz the power
Change committed as 170050
6 years, 9 months ago (2014-03-26 12:21:02 UTC) #7
skobes
6 years, 9 months ago (2014-03-28 01:40:48 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698