third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp - Issue 2121613003: Include style tags when pasting HTML content.

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp

Issue 2121613003: Include style tags when pasting HTML content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try to appease Windows linker. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "core/editing/commands/ReplaceSelectionCommand.h"

	6

	7 #include "bindings/core/v8/ExceptionState.h"

	8 #include "core/HTMLNames.h"

	9 #include "core/dom/DocumentFragment.h"

	10 #include "core/dom/ParserContentPolicy.h"

	11 #include "core/editing/FrameSelection.h"

	12 #include "core/editing/Position.h"

	13 #include "core/editing/VisibleSelection.h"

	14 #include "core/frame/FrameView.h"

	15 #include "core/frame/LocalFrame.h"

	16 #include "core/html/HTMLDocument.h"

	17 #include "core/testing/DummyPageHolder.h"

	18

	19 #include <gtest/gtest.h>
	tkent 2016/07/06 04:05:20 We should not use <> for gtest.h because it's not We should not use <> for gtest.h because it's not a system header. #include "testing/gtest/include/gtest/gtest.h"
	20 #include <memory>

	21

	22 namespace blink {

	23

	24 namespace {
	yosin_UTC9 2016/07/06 03:44:00 You don't need to put TEST() in anonymous namespac You don't need to put TEST() in anonymous namespace. Since gTest's namespace doesn't care about namespace. Note: We should put class in anonymous namespace.
	25

	26 // This is a regression test for https://crbug.com/121163

	27 TEST(ReplaceSelectionCommandTest, styleTagsInPastedHeadIncludedInContent)
	yosin_UTC9 2016/07/06 04:05:47 BTW, you can use EditingTestBase. https://cs.chrom BTW, you can use EditingTestBase. https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/E...
	28 {

	29 std::unique_ptr<DummyPageHolder> holder =

	30 DummyPageHolder::create(IntSize(1, 1));

	31 Document& document = holder->document();

	32 document.setDesignMode("on");

	33 holder->frame().selection().setSelection(

	34 VisibleSelection(Position(document.body(), 0)));

	35

	36 DocumentFragment* fragment = document.createDocumentFragment();

	37 fragment->parseHTML(
	yosin_UTC9 2016/07/06 03:44:01 This is the reason why it is better to use gTest r This is the reason why it is better to use gTest rather than layout-test. We can assemble a HTML fragment by the code. I used to be doing following magical thing. document.addEventListener('copy', event => { event.clipboardData.setData('text/html', '<span></span><span></span>'); event.clipboardData.setData('text/plain', ''); event.preventDefault(); }); // Put empty SPAN element with STYLE attribute into clipboard. document.execCommand('Copy'); Or, is it worth to do such magic to run layout test on Firefox and Edge? tkent 2016/07/06 04:05:20 The copy command needs a user gesture. So it's im Show quoted text On 2016/07/06 at 03:44:01, Yosi_UTC9 wrote: > This is the reason why it is better to use gTest rather than layout-test. > We can assemble a HTML fragment by the code. > > I used to be doing following magical thing. > > document.addEventListener('copy', event => { > event.clipboardData.setData('text/html', '<span></span><span></span>'); > event.clipboardData.setData('text/plain', ''); > event.preventDefault(); > }); > // Put empty SPAN element with STYLE attribute into clipboard. > document.execCommand('Copy'); > > Or, is it worth to do such magic to run layout test on Firefox and Edge? The copy command needs a user gesture. So it's impossible to write an interoperable automated JS test.
	38 "<head><style>foo { bar: baz; }</style></head>"

	39 "<body><p>Text</p></body>",

	40 document.documentElement(),

	41 DisallowScriptingAndPluginContent);

	42

	43 ReplaceSelectionCommand::CommandOptions options = 0;

	44 ReplaceSelectionCommand* command =

	45 ReplaceSelectionCommand::create(document, fragment, options);

	46 EXPECT_TRUE(command->apply())

	47 << "the replace command should have succeeded";

	48

	49 EXPECT_EQ(

	50 "<head><style>foo { bar: baz; }</style></head>"

	51 "<body><p>Text</p></body>",

	52 document.body()->innerHTML())

	53 << "the STYLE and P elements should have been pasted into the body "

	54 << "of the document";

	55 }

	56

	57 } // namespace

	58

	59 } // namespace blink

OLD	NEW