third_party/WebKit/LayoutTests/media/media-controls.js - Issue 2121613002: Convert video-controls-[captions, overlay, track]* tests to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/media-controls.js

Issue 2121613002: Convert video-controls-[captions, overlay, track]* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/video-controls-captions.html » ('j') | third_party/WebKit/LayoutTests/media/video-controls-captions.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/media-controls.js

diff --git a/third_party/WebKit/LayoutTests/media/media-controls.js b/third_party/WebKit/LayoutTests/media/media-controls.js

index b923623ff72fe17809c197bc339bbf72e5c5e7a2..5f5cbc8d6a90555ecef7deda17e9776de5e197df 100644

--- a/third_party/WebKit/LayoutTests/media/media-controls.js

+++ b/third_party/WebKit/LayoutTests/media/media-controls.js

@@ -174,9 +174,18 @@ function selectTextTrack(video, index)

clickAtCoordinates(trackListItemCoordinates[0], trackListItemCoordinates[1]);

}

+function selectTextTrackAtIndex(video, index)

+ var captionsButtonCoordinates = mediaControlsButtonCoordinates(video, "toggle-closed-captions-button");

+ clickAtCoordinates(captionsButtonCoordinates[0], captionsButtonCoordinates[1]);

+ var trackListItemElement = textTrackListItemAtIndex(video, index);

+ var trackListItemCoordinates = elementCoordinates(trackListItemElement);

+ clickAtCoordinates(trackListItemCoordinates[0], trackListItemCoordinates[1]);

function turnClosedCaptionsOff(video)

{

- selectTextTrack(video, -1);

+ selectTextTrackAtIndex(video, -1);

}

function runAfterHideMediaControlsTimerFired(func, mediaElement)