Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 21216003: Free slots buffer entries when tearing down the heap. (Closed)

Created:
7 years, 4 months ago by Hannes Payer (out of office)
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Free slots buffer entries when tearing down the heap. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15973

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
src/heap.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
src/mark-compact.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
src/mark-compact.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
7 years, 4 months ago (2013-07-30 09:15:00 UTC) #1
Michael Starzinger
LGTM (with one nit). https://codereview.chromium.org/21216003/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/21216003/diff/1/src/heap.cc#newcode6958 src/heap.cc:6958: mark_compact_collector()->AbortCompaction(); nit: Can we add ...
7 years, 4 months ago (2013-07-30 11:08:38 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/21216003/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/21216003/diff/1/src/heap.cc#newcode6958 src/heap.cc:6958: mark_compact_collector()->AbortCompaction(); On 2013/07/30 11:08:38, Michael Starzinger wrote: > nit: ...
7 years, 4 months ago (2013-07-31 07:13:36 UTC) #3
Hannes Payer (out of office)
7 years, 4 months ago (2013-07-31 07:17:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15973 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698