Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 21216002: Demonstrate that Web Audio does not keep callbacks alive long enough. (Closed)

Created:
7 years, 4 months ago by dominicc (has gone to gerrit)
Modified:
7 years, 4 months ago
Reviewers:
crogers, Chris Rogers
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Demonstrate that Web Audio does not keep callbacks alive long enough. This is discussed on Bug 82975. Unfortunately, not keeping the callback alive long enough encourages authors to implement a workaround which is prone to leaks by retaining (and typically leaking) a reference to the callback themselves. BUG=82795 R=crogers@google.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155194

Patch Set 1 #

Total comments: 7

Patch Set 2 : Patch for landing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
A LayoutTests/webaudio/scriptprocessornode-premature-death.html View 1 1 chunk +88 lines, -0 lines 0 comments Download
A LayoutTests/webaudio/scriptprocessornode-premature-death-expected.txt View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dominicc (has gone to gerrit)
PTAL Chris--for context, this is to demonstrate the utility of a new function in the ...
7 years, 4 months ago (2013-07-30 07:03:03 UTC) #1
dominicc (has gone to gerrit)
https://codereview.chromium.org/21216002/diff/1/LayoutTests/webaudio/javascriptaudionode-premature-death-expected.txt File LayoutTests/webaudio/javascriptaudionode-premature-death-expected.txt (right): https://codereview.chromium.org/21216002/diff/1/LayoutTests/webaudio/javascriptaudionode-premature-death-expected.txt#newcode6 LayoutTests/webaudio/javascriptaudionode-premature-death-expected.txt:6: FAIL wasCollectedPrematurely should be false. Was true. This is ...
7 years, 4 months ago (2013-07-30 07:06:06 UTC) #2
Chris Rogers
Dominic, thanks for looking at this. lgtm with nits https://codereview.chromium.org/21216002/diff/1/LayoutTests/webaudio/javascriptaudionode-premature-death.html File LayoutTests/webaudio/javascriptaudionode-premature-death.html (right): https://codereview.chromium.org/21216002/diff/1/LayoutTests/webaudio/javascriptaudionode-premature-death.html#newcode13 LayoutTests/webaudio/javascriptaudionode-premature-death.html:13: ...
7 years, 4 months ago (2013-07-30 18:55:54 UTC) #3
dominicc (has gone to gerrit)
Thanks for the feedback, Chris; I have improved the test. Hopefully this test gives someone ...
7 years, 4 months ago (2013-07-31 00:45:59 UTC) #4
dominicc (has gone to gerrit)
7 years, 4 months ago (2013-07-31 00:47:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r155194 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698