chrome/browser/apps/guest_view/web_view_browsertest.cc - Issue 2121513002: Replace string::find(prefix) == 0 pattern with base::StartsWith().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2121513002: Replace string::find(prefix) == 0 pattern with base::StartsWith(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typos Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/trace_event/trace_config.cc ('k') | chrome/browser/chromeos/profiles/profile_helper.cc » ('j') | chrome/test/chromedriver/session_commands.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/guest_view/web_view_browsertest.cc

diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc

index 5cd24d4cde654f215d2607f88e736b488591f8a7..f8f2f81348ef7136003d8377ac509ec84c8dcb67 100644

--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc

+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc

@@ -2355,7 +2355,8 @@ const char kDownloadPathPrefix[] = "/download_cookie_isolation_test";

std::unique_ptr<net::test_server::HttpResponse> HandleDownloadRequestWithCookie(

std::queue<net::HttpStatusCode>* status_codes,

const net::test_server::HttpRequest& request) {

- if (request.relative_url.find(kDownloadPathPrefix) != 0) {

+ if (!base::StartsWith(request.relative_url, kDownloadPathPrefix,

+ base::CompareCase::SENSITIVE)) {

return std::unique_ptr<net::test_server::HttpResponse>();

}

« no previous file with comments | « base/trace_event/trace_config.cc ('k') | chrome/browser/chromeos/profiles/profile_helper.cc » ('j') | chrome/test/chromedriver/session_commands.cc » ('J')