Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2121473002: mash: Move status area overview button to //ash/common (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move status area overview button to //ash/common It is a dependency of StatusAreaWidget, which I'm trying to move. It no longer has ash::Shell or aura/window dependencies. BUG=619636 TEST=ash_unittests Committed: https://crrev.com/0c6d15feee44c0d2bdbe61fe29a83e3700a7e08d Cr-Commit-Position: refs/heads/master@{#403914}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -236 lines) Patch
M ash/ash.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/common/system/overview/overview_button_tray.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/overview/overview_button_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/overview/overview_button_tray.h View 1 chunk +0 lines, -72 lines 0 comments Download
D ash/system/overview/overview_button_tray.cc View 1 chunk +0 lines, -156 lines 0 comments Download
M ash/system/overview/overview_button_tray_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/status_area_widget.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
James Cook
sky, can I get a rubber-stamp for this mechanical move?
4 years, 5 months ago (2016-07-01 23:53:04 UTC) #2
sky
LGTM
4 years, 5 months ago (2016-07-04 23:48:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121473002/20001
4 years, 5 months ago (2016-07-06 15:37:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-06 16:25:58 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 16:26:06 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 16:27:30 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c6d15feee44c0d2bdbe61fe29a83e3700a7e08d
Cr-Commit-Position: refs/heads/master@{#403914}

Powered by Google App Engine
This is Rietveld 408576698