Convert video-source-error* and video-source-inserted* tests to testharness.js

Convert video-source-error* and video-source-inserted* tests to testharness.js

Cleaning up video-source-error* and video-source-inserted*
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/376339f8ae53952e671b4bc9ea5cdb7afa503a05
Cr-Commit-Position: refs/heads/master@{#403622}

[Srirama, 2016-07-02 07:10:23]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert video-source-error* and video-source-inserted* tests to testharness.js

Cleaning up video-source-error* and video-source-inserted* 
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-07-02 07:11:28]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-07-02 07:11:29]

PTAL

[fs, 2016-07-02 17:56:57]

LGTM w/ nits

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html
(right):

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html:18: if
(++errorCount == 4)
Maybe assert errorCount < 4 or similar around here

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-source-error.html (right):

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-source-error.html:24: }, true);
assert_equals(video.error, null);

?

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-source-error.html:37:
assert_equals(url.substr(url.lastIndexOf("/media/") + 7), findMediaFile("video",
"content/test"));
Ditto

[Srirama, 2016-07-02 18:57:00]

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html
(right):

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html:18: if
(++errorCount == 4)
On 2016/07/02 17:56:56, fs wrote:
> Maybe assert errorCount < 4 or similar around here

We need the if condition for settimeout to end test. So you mean assert
errorcount in addition to this if?

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-source-error.html (right):

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-source-error.html:24: }, true);
On 2016/07/02 17:56:56, fs wrote:
> assert_equals(video.error, null);
> 
> ?

I have added video.onerror with unreached_func. Isn't it enough?

[fs, 2016-07-02 19:29:06]

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html
(right):

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html:18: if
(++errorCount == 4)
On 2016/07/02 at 18:56:59, Srirama wrote:
> On 2016/07/02 17:56:56, fs wrote:
> > Maybe assert errorCount < 4 or similar around here
> 
> We need the if condition for settimeout to end test. So you mean assert
errorcount in addition to this if?

In addition to, yes.

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-source-error.html (right):

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-source-error.html:24: }, true);
On 2016/07/02 at 18:56:59, Srirama wrote:
> On 2016/07/02 17:56:56, fs wrote:
> > assert_equals(video.error, null);
> > 
> > ?
> 
> I have added video.onerror with unreached_func. Isn't it enough?

Sorry, missed that.

[Srirama, 2016-07-03 03:43:52]

Patchset #2 (id:20001) has been deleted

[Srirama, 2016-07-03 03:46:09]

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html
(right):

https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html:18: if
(++errorCount == 4)
On 2016/07/02 19:29:06, fs wrote:
> On 2016/07/02 at 18:56:59, Srirama wrote:
> > On 2016/07/02 17:56:56, fs wrote:
> > > Maybe assert errorCount < 4 or similar around here
> > 
> > We need the if condition for settimeout to end test. So you mean assert
> errorcount in addition to this if?
> 
> In addition to, yes.

Done.

[Srirama, 2016-07-03 03:46:25]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-07-03 03:46:26]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2121453003/#ps40001
(title: "address nit")

[commit-bot: I haz the power, 2016-07-03 03:46:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-03 06:30:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-03 06:30:41]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Srirama, 2016-07-03 09:36:43]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-07-03 09:36:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 01:13:16]

Description was changed from

==========
Convert video-source-error* and video-source-inserted* tests to testharness.js

Cleaning up video-source-error* and video-source-inserted* 
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-source-error* and video-source-inserted* tests to testharness.js

Cleaning up video-source-error* and video-source-inserted* 
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-07-04 01:13:17]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-07-04 01:13:20]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-04 01:15:44]

Description was changed from

==========
Convert video-source-error* and video-source-inserted* tests to testharness.js

Cleaning up video-source-error* and video-source-inserted* 
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-source-error* and video-source-inserted* tests to testharness.js

Cleaning up video-source-error* and video-source-inserted*
tests in media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/376339f8ae53952e671b4bc9ea5cdb7afa503a05
Cr-Commit-Position: refs/heads/master@{#403622}
==========

[commit-bot: I haz the power, 2016-07-04 01:15:45]

Patchset 2 (id:??) landed as
https://crrev.com/376339f8ae53952e671b4bc9ea5cdb7afa503a05
Cr-Commit-Position: refs/heads/master@{#403622}