Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2121453003: Convert video-source-error* and video-source-inserted* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-source-error* and video-source-inserted* tests to testharness.js Cleaning up video-source-error* and video-source-inserted* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/376339f8ae53952e671b4bc9ea5cdb7afa503a05 Cr-Commit-Position: refs/heads/master@{#403622}

Patch Set 1 #

Total comments: 8

Patch Set 2 : address nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -223 lines) Patch
M third_party/WebKit/LayoutTests/media/video-source-error.html View 1 chunk +40 lines, -78 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-source-error-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html View 1 1 chunk +23 lines, -62 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-source-error-no-candidate-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-source-inserted.html View 1 chunk +20 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-source-inserted-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-02 07:11:29 UTC) #3
fs
LGTM w/ nits https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html File third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html (right): https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html#newcode18 third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html:18: if (++errorCount == 4) Maybe assert ...
4 years, 5 months ago (2016-07-02 17:56:57 UTC) #4
Srirama
https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html File third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html (right): https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html#newcode18 third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html:18: if (++errorCount == 4) On 2016/07/02 17:56:56, fs wrote: ...
4 years, 5 months ago (2016-07-02 18:57:00 UTC) #5
fs
https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html File third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html (right): https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html#newcode18 third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html:18: if (++errorCount == 4) On 2016/07/02 at 18:56:59, Srirama ...
4 years, 5 months ago (2016-07-02 19:29:06 UTC) #6
Srirama
https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html File third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html (right): https://codereview.chromium.org/2121453003/diff/1/third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html#newcode18 third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html:18: if (++errorCount == 4) On 2016/07/02 19:29:06, fs wrote: ...
4 years, 5 months ago (2016-07-03 03:46:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121453003/40001
4 years, 5 months ago (2016-07-03 03:46:32 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/256655)
4 years, 5 months ago (2016-07-03 06:30:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121453003/40001
4 years, 5 months ago (2016-07-03 09:36:50 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-04 01:13:17 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 01:13:20 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 01:15:45 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/376339f8ae53952e671b4bc9ea5cdb7afa503a05
Cr-Commit-Position: refs/heads/master@{#403622}

Powered by Google App Engine
This is Rietveld 408576698