Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2121433002: Fix navigator.plugins and navigator.mimeTypes for OOPIFs. (Closed)

Created:
4 years, 5 months ago by alexmos
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix navigator.plugins and navigator.mimeTypes for OOPIFs. Previously, Page::pluginData() returned nullptr when the Page's main frame was a RemoteFrame. This caused navigator.plugins and navigator.mimeTypes to both return empty arrays from an OOPIF. Page::pluginData() needed the main frame to run the FrameLoader::allowPlugins check on it. This CL moves this check to happen on the actual LocalFrame that needs to access Page::pluginData(). BUG=612200, 607981, 616445 Review-Url: https://codereview.chromium.org/1990343002 Cr-Commit-Position: refs/heads/master@{#394942} (cherry picked from commit fb92f3e718335521cf454e53651235fbf30c10e2) Committed: https://chromium.googlesource.com/chromium/src/+/bc0578a78ae310a0216210e9e6894537acb7d8e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +0 lines, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/plugins/navigator-plugins-in-cross-origin-frame.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/plugins/navigator-plugins-in-cross-origin-frame-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/plugins/resources/navigator-plugins.js View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/plugins/resources/navigator-plugins-frame.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMImplementation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMMimeTypeArray.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
alexmos
4 years, 5 months ago (2016-07-01 22:08:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bc0578a78ae310a0216210e9e6894537acb7d8e6.

Powered by Google App Engine
This is Rietveld 408576698