Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2121413002: Support selection and copying over non-editable content in ChromeVox Next. (Closed)

Created:
4 years, 5 months ago by David Tseng
Modified:
4 years, 5 months ago
Reviewers:
nektarios, dmazzoni
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support selection and copying over non-editable content in ChromeVox Next. What works: - search+s toggles on / off a DOM-based selection - selection by character, word, line, object work across multiple nodes* - announcement of what gets read via a clipboard hack - ctrl+c is observed and reads out copy events in lue of an actual copy event in the DOM (we're at a disadvantage here) *works currently for basic examples. The underlying "framework" fails in slightly more complex cases like a paragraph with a link in it or a line break. For example, a link followed by a static text fails when attempting to select the static text via index offsets. Likely a Blink issue. BUG=513716 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2e2288282d460c027b3a306d36a096c30700096b Cr-Commit-Position: refs/heads/master@{#404570}

Patch Set 1 #

Patch Set 2 : Fix test. #

Patch Set 3 : Work around blink bug. #

Patch Set 4 : Fix test. #

Messages

Total messages: 18 (10 generated)
David Tseng
4 years, 5 months ago (2016-07-06 17:06:00 UTC) #4
nektarios
lgtm
4 years, 5 months ago (2016-07-08 20:09:35 UTC) #5
nektarios
I can't say I have any experience with this code base, but as far as ...
4 years, 5 months ago (2016-07-08 20:10:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121413002/40001
4 years, 5 months ago (2016-07-08 21:40:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/198506)
4 years, 5 months ago (2016-07-08 22:15:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121413002/60001
4 years, 5 months ago (2016-07-09 20:11:14 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-09 20:53:32 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-09 20:55:36 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2e2288282d460c027b3a306d36a096c30700096b
Cr-Commit-Position: refs/heads/master@{#404570}

Powered by Google App Engine
This is Rietveld 408576698