Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2121403002: Enabling TabManager on testing browser process (Closed)

Created:
4 years, 5 months ago by Anderson Silva
Modified:
4 years, 5 months ago
Reviewers:
Georges Khalil, chrisha, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

To make it possible run all TabManager based browsertests as unittest. BUG=625850 Committed: https://crrev.com/13af30c7bfb22dae8f79ebe203d959c71c711a37 Cr-Commit-Position: refs/heads/master@{#403960}

Patch Set 1 #

Patch Set 2 : adding comment #

Total comments: 3

Patch Set 3 : fixing comment #

Patch Set 4 : modified comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/test/base/testing_browser_process.h View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Anderson Silva
PTAL
4 years, 5 months ago (2016-07-06 17:54:29 UTC) #3
Georges Khalil
LGTM % nit. https://codereview.chromium.org/2121403002/diff/20001/chrome/test/base/testing_browser_process.h File chrome/test/base/testing_browser_process.h (right): https://codereview.chromium.org/2121403002/diff/20001/chrome/test/base/testing_browser_process.h#newcode183 chrome/test/base/testing_browser_process.h:183: // invoked in suppoerted platforms. nit ...
4 years, 5 months ago (2016-07-06 18:00:04 UTC) #4
Georges Khalil
Modified comment. https://codereview.chromium.org/2121403002/diff/20001/chrome/test/base/testing_browser_process.h File chrome/test/base/testing_browser_process.h (right): https://codereview.chromium.org/2121403002/diff/20001/chrome/test/base/testing_browser_process.h#newcode183 chrome/test/base/testing_browser_process.h:183: // invoked in suppoerted platforms. On 2016/07/06 ...
4 years, 5 months ago (2016-07-06 18:00:45 UTC) #5
Anderson Silva
Changed comment. https://codereview.chromium.org/2121403002/diff/20001/chrome/test/base/testing_browser_process.h File chrome/test/base/testing_browser_process.h (right): https://codereview.chromium.org/2121403002/diff/20001/chrome/test/base/testing_browser_process.h#newcode183 chrome/test/base/testing_browser_process.h:183: // invoked in suppoerted platforms. On 2016/07/06 ...
4 years, 5 months ago (2016-07-06 18:11:11 UTC) #6
Anderson Silva
Hi, Can you please take a look at this? Thanks
4 years, 5 months ago (2016-07-06 18:43:21 UTC) #8
sky
LGTM
4 years, 5 months ago (2016-07-06 20:34:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121403002/60001
4 years, 5 months ago (2016-07-06 20:57:20 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-06 22:09:18 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 22:09:44 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 22:11:08 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/13af30c7bfb22dae8f79ebe203d959c71c711a37
Cr-Commit-Position: refs/heads/master@{#403960}

Powered by Google App Engine
This is Rietveld 408576698