Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: runtime/vm/object.h

Issue 2121383003: Add NosafepointScope and remove comment. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 143cf9e409ac4647df55b2b7b58f3ad3ea61cb2e..4dcade6c39e0b0a554092e1c31455df1c2041889 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -8531,9 +8531,7 @@ RawClass* Object::clazz() const {
DART_FORCE_INLINE void Object::SetRaw(RawObject* value) {
- // NOTE: The assignment "raw_ = value" should be the first statement in
- // this function. Also do not use 'value' in this function after the
- // assignment (use 'raw_' instead).
+ NoSafepointScope no_safepoint_scope;
raw_ = value;
if ((reinterpret_cast<uword>(value) & kSmiTagMask) == kSmiTag) {
set_vtable(Smi::handle_vtable_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698