Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2121343004: Expose whether unittest failed to tearDown(). (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
Reviewers:
Sergiy Byelozyorov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/testing/expect_tests.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Expose whether unittest failed to tearDown(). Use-case: check performed in tearDown() that fails because the actual test fails. In such a case, original failure exception would be overwritten, hiding real cause and confusing developer who is trying to make sense of it. Example: thread watcher, checks that all new threads are terminated before test finishes: https://codereview.chromium.org/2127943002/ BUG= Committed: https://chromium.googlesource.com/infra/testing/expect_tests/+/b125b3d0b93c533f72bee3d3725fec5aeaa5d3a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M expect_tests/unittest_helper.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
tandrii(chromium)
PTAL this is to make https://codereview.chromium.org/2127943002/ useful when tests are run by expect_tests.
4 years, 5 months ago (2016-07-06 16:35:53 UTC) #2
Sergiy Byelozyorov
lgtm
4 years, 5 months ago (2016-07-07 07:04:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Reference: codereview.chromium.org/2121343004/1
4 years, 5 months ago (2016-07-07 09:00:09 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 09:00:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/testing/expect_tests/+/b125b3d0b93c53...

Powered by Google App Engine
This is Rietveld 408576698