Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2121343002: [zlib] Fix unmangled symbols. (Closed)

Created:
4 years, 5 months ago by altimin
Modified:
4 years, 4 months ago
Reviewers:
agl, gavinp
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a number of symbols which are not mangled in mozzconf.h, but should be. Committed: https://crrev.com/3ebc568312f7a2c48dac5a5a7118e257456af405 Cr-Commit-Position: refs/heads/master@{#408157}

Patch Set 1 #

Patch Set 2 : Mangle other symbols too #

Patch Set 3 : Fix compilation #

Patch Set 4 : Modify .patch files to reflect current condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M third_party/zlib/README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google.patch View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/zlib/mozzconf.h View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/zlib/simd.patch View 1 2 3 2 chunks +23 lines, -2 lines 0 comments Download
M third_party/zlib/x86.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
altimin
4 years, 5 months ago (2016-07-06 16:05:46 UTC) #2
altimin
4 years, 4 months ago (2016-07-26 13:07:18 UTC) #4
agl
What prompted this? Although it looks correct, I also see the following unmangled symbols: 0000000000000000 ...
4 years, 4 months ago (2016-07-26 15:13:01 UTC) #5
altimin
PTAL. (I've also updated version in README.chromium to a correct one, since presubmit checks want ...
4 years, 4 months ago (2016-07-26 17:00:12 UTC) #7
gavinp
On 2016/07/26 17:00:12, altimin wrote: > PTAL. > > (I've also updated version in README.chromium ...
4 years, 4 months ago (2016-07-26 17:34:35 UTC) #8
altimin
On 2016/07/26 17:34:35, gavinp wrote: > On 2016/07/26 17:00:12, altimin wrote: > > PTAL. > ...
4 years, 4 months ago (2016-07-27 10:59:36 UTC) #9
gavinp
lgtm
4 years, 4 months ago (2016-07-27 15:13:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121343002/60001
4 years, 4 months ago (2016-07-27 15:35:33 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-07-27 16:52:31 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 16:54:06 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3ebc568312f7a2c48dac5a5a7118e257456af405
Cr-Commit-Position: refs/heads/master@{#408157}

Powered by Google App Engine
This is Rietveld 408576698