Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2121313004: Revert of Better encapsulate oval/rrect batchs. (Closed)

Created:
4 years, 5 months ago by hush (inactive)
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Better encapsulate oval/rrect batchs. (patchset #5 id:80001 of https://codereview.chromium.org/2104423003/ ) Reason for revert: This CL is suspected to break compilation on arm64. https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/5851/steps/compile/logs/stdio Original issue's description: > Better encapsulate oval/rrect batchs. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104423003 > > Committed: https://skia.googlesource.com/skia/+/5fd209e8ee477c703bc5c11b008f247d515fc0fc > Committed: https://skia.googlesource.com/skia/+/7f06c6947a3bef78dc57b9252779567c33604c90 > Committed: https://skia.googlesource.com/skia/+/11bf8b2eae7d1780cb969146422a2ab3b933047a TBR=robertphillips@google.com,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/c79fc33d3e83664ffbd3651df3131c3e9e0b635c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+435 lines, -392 lines) Patch
M src/gpu/GrOvalRenderer.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 17 chunks +422 lines, -392 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hush (inactive)
Created Revert of Better encapsulate oval/rrect batchs.
4 years, 5 months ago (2016-07-07 20:51:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121313004/1
4 years, 5 months ago (2016-07-07 20:52:04 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 5 months ago (2016-07-07 20:52:06 UTC) #4
bsalomon
lgtm
4 years, 5 months ago (2016-07-07 20:56:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/c79fc33d3e83664ffbd3651df3131c3e9e0b635c
4 years, 5 months ago (2016-07-07 20:58:42 UTC) #7
bsalomon
4 years, 5 months ago (2016-07-08 11:42:32 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2134693002/ by bsalomon@google.com.

The reason for reverting is: Workaround for compiler/stdlib bug landed:
https://codereview.chromium.org/2135453002.

Powered by Google App Engine
This is Rietveld 408576698