third_party/WebKit/Source/core/page/TouchAdjustment.cpp - Issue 2121313003: [Editing][DOM][CodeHealth] Make Node::isContentEditable and Node::isRichEditable global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/TouchAdjustment.cpp

Issue 2121313003: [Editing][DOM][CodeHealth] Make Node::isContentEditable and Node::isRichEditable global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/page/DragController.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/TouchAdjustment.cpp

diff --git a/third_party/WebKit/Source/core/page/TouchAdjustment.cpp b/third_party/WebKit/Source/core/page/TouchAdjustment.cpp

index 57c1e3c8d52c8962da65314cc90df1777a3ce9f0..f2d31df84715ba34ddf834812da3b11d37b5eb46 100644

--- a/third_party/WebKit/Source/core/page/TouchAdjustment.cpp

+++ b/third_party/WebKit/Source/core/page/TouchAdjustment.cpp

@@ -116,7 +116,7 @@ bool providesContextMenuItems(Node* node)

ASSERT(node->layoutObject() || node->isShadowRoot());

if (!node->layoutObject())

return false;

- if (node->isContentEditable())

+ if (isContentEditable(*node))

return true;

if (node->isLink())

return true;

@@ -298,10 +298,10 @@ void compileSubtargetList(const HeapVector<Member<Node>>& intersectedNodes, Subt

// Consolidate bounds for editable content.

if (editableAncestors.contains(candidate))

continue;

- if (candidate->isContentEditable()) {

+ if (isContentEditable(*candidate)) {

Node* replacement = candidate;

Node* parent = candidate->parentOrShadowHostNode();

- while (parent && parent->isContentEditable()) {

+ while (parent && isContentEditable(*parent)) {

replacement = parent;

if (editableAncestors.contains(replacement)) {

replacement = nullptr;