third_party/WebKit/Source/web/WebNode.cpp - Issue 2121313003: [Editing][DOM][CodeHealth] Make Node::isContentEditable and Node::isRichEditable global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebNode.cpp

Issue 2121313003: [Editing][DOM][CodeHealth] Make Node::isContentEditable and Node::isRichEditable global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLElement.cpp ('K') | « third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp ('k') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebNode.cpp

diff --git a/third_party/WebKit/Source/web/WebNode.cpp b/third_party/WebKit/Source/web/WebNode.cpp

index 60933dfc3e5d55f999bb1e8090c34c458e73dc68..44ef00b9510a6df7a0e1842dbddacded138e83aa 100644

--- a/third_party/WebKit/Source/web/WebNode.cpp

+++ b/third_party/WebKit/Source/web/WebNode.cpp

@@ -171,7 +171,7 @@ bool WebNode::isFocusable() const

bool WebNode::isContentEditable() const

tkent 2016/07/21 08:28:44 I found this function was not used and we should r

yoichio 2016/07/21 08:36:33 Acknowledged.

tkent 2016/07/25 01:54:16 I was wrong. It's used only for Android. RenderW

{

- return m_private->isContentEditable();

+ return blink::isContentEditable(*m_private);

}

bool WebNode::isInsideFocusableElementOrARIAWidget() const