third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp - Issue 2121313003: [Editing][DOM][CodeHealth] Make Node::isContentEditable and Node::isRichEditable global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp

Issue 2121313003: [Editing][DOM][CodeHealth] Make Node::isContentEditable and Node::isRichEditable global functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/DeleteFromTextNodeCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/RemoveNodeCommand.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp

index edcc46551bcf03d2922cd2b9ec77e8ec7eb076ef..4dcbbbd275d17fb44f3d13e2aa9eb11628d5e605 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertNodeBeforeCommand.cpp

@@ -47,16 +47,16 @@ InsertNodeBeforeCommand::InsertNodeBeforeCommand(Node* insertChild, Node* refChi

void InsertNodeBeforeCommand::doApply(EditingState*)

{

ContainerNode* parent = m_refChild->parentNode();

- if (!parent || (m_shouldAssumeContentIsAlwaysEditable == DoNotAssumeContentIsAlwaysEditable && !parent->isContentEditable()))

+ if (!parent || (m_shouldAssumeContentIsAlwaysEditable == DoNotAssumeContentIsAlwaysEditable && !isContentEditable(*parent)))

return;

- DCHECK(parent->isContentEditable()) << parent;

+ DCHECK(isContentEditable(*parent)) << parent;

parent->insertBefore(m_insertChild.get(), m_refChild.get(), IGNORE_EXCEPTION);

}

void InsertNodeBeforeCommand::doUnapply()

{

- if (!m_insertChild->isContentEditable())

+ if (!isContentEditable(*m_insertChild))

return;

m_insertChild->remove(IGNORE_EXCEPTION);