[sensors] Generic Sensors Framework blink side

third_party/WebKit/Source/modules/sensor/SensorReading.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SensorReading_h
 #define SensorReading_h
 
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "core/dom/DOMHighResTimeStamp.h"
 #include "core/dom/DOMTimeStamp.h"
-#include "modules/ModulesExport.h"
+#include "modules/sensor/SensorProxy.h"
 
 namespace blink {
 
-class MODULES_EXPORT SensorReading : public GarbageCollectedFinalized<SensorReading>, public ScriptWrappable {
+class ExecutionContext;
+
+class SensorReading
+    : public GarbageCollected<SensorReading>
+    , public ScriptWrappable {
     DEFINE_WRAPPERTYPEINFO();
-
 public:
-    static SensorReading* create()
-    {
-        return new SensorReading;
-    }
-
-    static SensorReading* create(bool providesTimeStamp, DOMHighResTimeStamp timestamp)
-    {
-        return new SensorReading(providesTimeStamp, timestamp);
-    }
-
-    virtual ~SensorReading();
-
-    DOMHighResTimeStamp timeStamp(bool& isNull);
-
-    void setTimeStamp(DOMHighResTimeStamp time) { m_timeStamp = time; }
-
     DECLARE_VIRTUAL_TRACE();
 
+    DOMHighResTimeStamp timeStamp() const;
+
+    void attach(SensorProxy*);
+    void detach();
+
+    virtual bool isReadingUpdated(const SensorProxy::Reading& previous) const = 0;
+
 protected:
-    bool m_canProvideTimeStamp;
-    DOMHighResTimeStamp m_timeStamp;
+    explicit SensorReading(ExecutionContext*);
 
-    SensorReading();
-    SensorReading(bool providesTimeStamp, DOMHighResTimeStamp timestamp);
+protected:
+    WeakMember<SensorProxy> m_sensorProxy;
+    WeakMember<ExecutionContext> m_context;

[haraken, 2016/09/06 05:04:29]

Is there any reason they need to be weak members?

[Mikhail, 2016/09/06 07:13:58]

'm_sensorProxy' might have a different lifetime (same as inside Sensor)
Is it fine to keep a strong reference to 'm_context' from here (member)?

 };
 
 } // namepsace blink
 
 #endif // SensorReading_h