[sensors] Generic Sensors Framework blink side

third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "modules/sensor/SensorProviderProxy.h"
+
+#include "core/frame/LocalFrame.h"
+#include "modules/sensor/SensorProxy.h"
+#include "platform/mojo/MojoHelper.h"
+#include "public/platform/InterfaceProvider.h"
+
+namespace blink {
+
+const char SensorProviderProxy::s_supplementKey[] = "SensorProvider";

[haraken, 2016/09/06 05:04:28]

Use supplementName() just like what other supplement objects are doing.

+
+// SensorProviderProxy
+SensorProviderProxy::SensorProviderProxy(LocalFrame* frame)
+    : PageVisibilityObserver(frame->document() ? frame->document()->page() : nullptr)
+    , m_frame(frame)
+{
+    frame->interfaceProvider()->getInterface(mojo::GetProxy(&m_sensorProvider));
+    m_sensorProvider.set_connection_error_handler(convertToBaseCallback(WTF::bind(&SensorProviderProxy::handleSensorError, wrapWeakPersistent(this))));
+}
+
+SensorProviderProxy* SensorProviderProxy::getOrCreateForFrame(LocalFrame* frame)
+{
+    DCHECK(frame);
+    SensorProviderProxy* result = static_cast<SensorProviderProxy*>(Supplement<LocalFrame>::from(*frame, s_supplementKey));
+    if (!result) {
+        result = new SensorProviderProxy(frame);
+        Supplement<LocalFrame>::provideTo(*frame, s_supplementKey, result);
+    }
+    return result;
+}
+
+SensorProviderProxy::~SensorProviderProxy()
+{
+}
+
+DEFINE_TRACE(SensorProviderProxy)
+{
+    visitor->trace(m_sensors);
+    visitor->trace(m_frame);
+    PageVisibilityObserver::trace(visitor);
+    Supplement<LocalFrame>::trace(visitor);
+}
+
+void SensorProviderProxy::removeSensor(SensorProxy* sensor)
+{
+    m_sensors.remove(sensor);
+}
+
+SensorProxy* SensorProviderProxy::getOrCreateSensor(device::mojom::blink::SensorType type)
+{
+    for (SensorProxy* sensor : m_sensors) {
+        // TODO(Mikhail) : Hash sensors by type for efficiency.
+        if (sensor->type() == type)
+            return sensor;
+    }
+    SensorProxy* sensor = new SensorProxy(type, this);
+    m_sensors.add(sensor);
+
+    return sensor;
+}
+
+void SensorProviderProxy::handleSensorError()
+{
+    SensorsSet copy(m_sensors);

[haraken, 2016/09/06 05:04:29]

Use copyToVector.

+    for (SensorProxy* sensor : copy) {
+        // All sensors are invalidated.
+        sensor->handleSensorError();
+    }
+    DCHECK(m_sensors.isEmpty());
+    if (m_frame)
+        m_frame->removeSupplement(s_supplementKey);

[haraken, 2016/09/06 05:04:28]

We normally don't remove supplement objects from the map. You can leave it as
is.

+}
+
+void SensorProviderProxy::pageVisibilityChanged()
+{
+    if (!m_frame)
+        return;
+
+    Page* page = m_frame->document()->page();

[haraken, 2016/09/06 05:04:29]

Just use PageVisibilityObserver::page().

[Mikhail, 2016/09/06 07:13:58]

indeed, thanks

+    DCHECK(page);
+
+    if (page->visibilityState() != PageVisibilityStateVisible) {
+        for (SensorProxy* sensor : m_sensors)
+            sensor->suspend();
+    } else {
+        for (SensorProxy* sensor : m_sensors)
+            sensor->resume();
+    }
+}
+
+} // namespace blink