Remove the "Settings" packaged app

Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on
non-chromeos platforms. But this hasn't been available on those
platforms for 1 milestone (since r394856), so it's time to purge the
associated code.

Note this is different to the ChromeOS Settings "App"
(chrome://flags/#enable-settings-window), and the arc / Android "App
Settings" App (arc:kSettingsAppId and b/28017599).

BUG=263236, 600915
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/824bea8069b71ecb4f8c94fbeb78d19196304f1c
Cr-Commit-Position: refs/heads/master@{#404968}

[tapted, 2016-07-07 00:12:18]

Description was changed from

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on non-
chromeos platforms. But this has been a contradiction for 1 mileston, so
it's time to purge the associated code.

Note this is different to the ChromeOS Settings "App", and the arc /
Android Settings App.

BUG=263236
==========

to

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on non-
chromeos platforms. But this has been a contradiction for 1 mileston, so
it's time to purge the associated code.

Note this is different to the ChromeOS Settings "App", and the arc /
Android Settings App.

BUG=263236
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tapted, 2016-07-07 00:29:02]

Description was changed from

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on non-
chromeos platforms. But this has been a contradiction for 1 mileston, so
it's time to purge the associated code.

Note this is different to the ChromeOS Settings "App", and the arc /
Android Settings App.

BUG=263236
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on non-
chromeos platforms. But this has been a contradiction for 1 milestone, so
it's time to purge the associated code.

Note this is different to the ChromeOS Settings "App", and the arc /
Android Settings App.

BUG=263236
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tapted, 2016-07-07 00:38:01]

Description was changed from

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on non-
chromeos platforms. But this has been a contradiction for 1 milestone, so
it's time to purge the associated code.

Note this is different to the ChromeOS Settings "App", and the arc /
Android Settings App.

BUG=263236
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on
non- chromeos platforms. But this has been a contradiction for 1
milestone, so it's time to purge the associated code.

Note this is different to the ChromeOS Settings "App"
(chrome://flags/#enable-settings-window), and the arc / Android Settings
App.

BUG=263236
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tapted, 2016-07-07 01:19:06]

Description was changed from

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on
non- chromeos platforms. But this has been a contradiction for 1
milestone, so it's time to purge the associated code.

Note this is different to the ChromeOS Settings "App"
(chrome://flags/#enable-settings-window), and the arc / Android Settings
App.

BUG=263236
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on
non-chromeos platforms. But this has been a contradiction for 1
milestone (since r394856), so it's time to purge the associated code.

Note this is different to the ChromeOS Settings "App"
(chrome://flags/#enable-settings-window), and the arc / Android "App
Settings" App (arc:kSettingsAppId and b/28017599).

BUG=263236
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tapted, 2016-07-07 01:20:55]

Description was changed from

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on
non-chromeos platforms. But this has been a contradiction for 1
milestone (since r394856), so it's time to purge the associated code.

Note this is different to the ChromeOS Settings "App"
(chrome://flags/#enable-settings-window), and the arc / Android "App
Settings" App (arc:kSettingsAppId and b/28017599).

BUG=263236
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on
non-chromeos platforms. But this has been a contradiction for 1
milestone (since r394856), so it's time to purge the associated code.

Note this is different to the ChromeOS Settings "App"
(chrome://flags/#enable-settings-window), and the arc / Android "App
Settings" App (arc:kSettingsAppId and b/28017599).

BUG=263236, 600915
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tapted, 2016-07-07 01:20:55]

tapted@chromium.org changed reviewers:
+ mgiuca@chromium.org

[tapted, 2016-07-07 01:21:41]

Hi Matt, please take a look

[Matt Giuca, 2016-07-07 04:40:21]

> But this has been a contradiction for 1
milestone (since r394856)

Can you clarify that as "But this hasn't been available on those platforms for 1
milestone..."?

lgtm

[tapted, 2016-07-07 05:49:46]

Description was changed from

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on
non-chromeos platforms. But this has been a contradiction for 1
milestone (since r394856), so it's time to purge the associated code.

Note this is different to the ChromeOS Settings "App"
(chrome://flags/#enable-settings-window), and the arc / Android "App
Settings" App (arc:kSettingsAppId and b/28017599).

BUG=263236, 600915
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on
non-chromeos platforms. But this hasn't been available on those
platforms for 1 milestone (since r394856), so it's time to purge the
associated code.

Note this is different to the ChromeOS Settings "App"
(chrome://flags/#enable-settings-window), and the arc / Android "App
Settings" App (arc:kSettingsAppId and b/28017599).

BUG=263236, 600915
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tapted, 2016-07-07 06:35:11]

tapted@chromium.org changed reviewers:
+ dbeam@chromium.org, oshima@chromium.org

[tapted, 2016-07-07 06:39:47]

tapted@chromium.org changed reviewers:
+ rockot@chromium.org, thakis@chromium.org

[tapted, 2016-07-07 06:40:38]

tapted@chromium.org changed reviewers:
+ brettw@chromium.org
- thakis@chromium.org

[tapted, 2016-07-07 06:43:49]

On 2016/07/07 04:40:21, Matt Giuca wrote:
> > But this has been a contradiction for 1
> milestone (since r394856)
> 
> Can you clarify that as "But this hasn't been available on those platforms for
1
> milestone..."?
> 
> lgtm

[tapted, 2016-07-07 06:44:41]

+OWNERS

oshima: src/ash and chrome/app/theme
dbeam: c/b/resources and c/b/ui/webui
brettw: c/b/e/component_extensions_whitelist/whitelist.cc, src/build,
build/config and src/tools
rockot: c/common/extensions

Thanks!


On 2016/07/07 04:40:21, Matt Giuca wrote:
> > But this has been a contradiction for 1
> milestone (since r394856)
> 
> Can you clarify that as "But this hasn't been available on those platforms for
1
> milestone..."?

Done.

[oshima, 2016-07-07 10:10:28]

ash, c/a/theme lgtm

[Ken Rockot(use gerrit already), 2016-07-07 13:13:37]

lgtm

[Dan Beam, 2016-07-08 23:39:21]

lgtm

[tapted, 2016-07-11 23:47:30]

brettw: ping for OWNERS in
 - build/config/*
 - chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
 - tools/gn/*
 - Also build/common.gypi and tools/grit/grit_rule.gni

Thanks!

[brettw, 2016-07-12 20:27:55]

Aforementioned things LGTM. Yay for deleting all of this.

[tapted, 2016-07-12 23:18:11]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-07-12 23:20:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 00:43:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 00:43:21]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tapted, 2016-07-13 02:34:34]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2016-07-13 02:36:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 03:38:08]

Description was changed from

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on
non-chromeos platforms. But this hasn't been available on those
platforms for 1 milestone (since r394856), so it's time to purge the
associated code.

Note this is different to the ChromeOS Settings "App"
(chrome://flags/#enable-settings-window), and the arc / Android "App
Settings" App (arc:kSettingsAppId and b/28017599).

BUG=263236, 600915
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on
non-chromeos platforms. But this hasn't been available on those
platforms for 1 milestone (since r394856), so it's time to purge the
associated code.

Note this is different to the ChromeOS Settings "App"
(chrome://flags/#enable-settings-window), and the arc / Android "App
Settings" App (arc:kSettingsAppId and b/28017599).

BUG=263236, 600915
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-13 03:38:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 03:40:05]

Description was changed from

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on
non-chromeos platforms. But this hasn't been available on those
platforms for 1 milestone (since r394856), so it's time to purge the
associated code.

Note this is different to the ChromeOS Settings "App"
(chrome://flags/#enable-settings-window), and the arc / Android "App
Settings" App (arc:kSettingsAppId and b/28017599).

BUG=263236, 600915
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove the "Settings" packaged app

`enable_settings_app` was previously enabled for the app launcher on
non-chromeos platforms. But this hasn't been available on those
platforms for 1 milestone (since r394856), so it's time to purge the
associated code.

Note this is different to the ChromeOS Settings "App"
(chrome://flags/#enable-settings-window), and the arc / Android "App
Settings" App (arc:kSettingsAppId and b/28017599).

BUG=263236, 600915
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/824bea8069b71ecb4f8c94fbeb78d19196304f1c
Cr-Commit-Position: refs/heads/master@{#404968}
==========

[commit-bot: I haz the power, 2016-07-13 03:40:07]

Patchset 1 (id:??) landed as
https://crrev.com/824bea8069b71ecb4f8c94fbeb78d19196304f1c
Cr-Commit-Position: refs/heads/master@{#404968}