Issue 21213003: make Intl non-enumerable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21213003: make Intl non-enumerable (Closed)

Created:
7 years, 4 months ago by dcarney

Modified:
7 years, 4 months ago

Reviewers:
Sven Panne, jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/extensions/i18n/footer.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/extensions/i18n/header.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

jochen (gone - plz use gerrit)

Dan tells me that the intl tests still pass with this, so lgtm

7 years, 4 months ago (2013-07-31 06:42:51 UTC) #3

Sven Panne

LGTM, too. I guess in the end this will end up using some %SetProperty(global, ...) ...

7 years, 4 months ago (2013-07-31 06:44:25 UTC) #4

dcarney

7 years, 4 months ago (2013-07-31 07:17:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r15974 (presubmit successful).