Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2121293004: Reland of Fix initialization ordering in GLES2CmdDecoder. (Closed)

Created:
4 years, 5 months ago by phoglund_chromium
Modified:
4 years, 5 months ago
Reviewers:
erikchen, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fix initialization ordering in GLES2CmdDecoder. (patchset #1 id:1 of https://codereview.chromium.org/2126183002/ ) Reason for revert: This patch was probably innocent, https://codereview.chromium.org/2112783002/ was probably guilty. Original issue's description: > Revert of Fix initialization ordering in GLES2CmdDecoder. (patchset #2 id:20001 of https://codereview.chromium.org/2105153002/ ) > > Reason for revert: > Appears to break GPU webkit tests on Mac and Linux. This revert is a bit speculative since there are like 4 more gpu-related patches in the blame list, but the error messages does mention gles2_cmd_decoder.cc, so picking this patch as the first victim. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/34148/steps/webkit_tests/logs/stdio > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/24915 > > Original issue's description: > > Fix initialization ordering in GLES2CmdDecoder. > > > > The ContextGroup must be initialized before feature flag checks will work > > correctly. > > > > BUG=602484 > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > > > > Committed: https://crrev.com/477e47082e76afca7c2e656a0714ee24e67fb702 > > Cr-Commit-Position: refs/heads/master@{#404019} > > TBR=piman@chromium.org,erikchen@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=602484 > > Committed: https://crrev.com/39de5e1f08c3162866e42b8cf932fdef0237c92a > Cr-Commit-Position: refs/heads/master@{#404112} TBR=piman@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602484 Committed: https://crrev.com/2e0756e995089857af2491de1a21188d64248fe3 Cr-Commit-Position: refs/heads/master@{#404147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -29 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +17 lines, -18 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 2 chunks +1 line, -8 lines 0 comments Download
M gpu/command_buffer/tests/gl_native_gmb_backbuffer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
phoglund_chromium
Created Reland of Fix initialization ordering in GLES2CmdDecoder.
4 years, 5 months ago (2016-07-07 13:43:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121293004/1
4 years, 5 months ago (2016-07-07 13:44:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 13:44:55 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 13:45:09 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 13:46:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e0756e995089857af2491de1a21188d64248fe3
Cr-Commit-Position: refs/heads/master@{#404147}

Powered by Google App Engine
This is Rietveld 408576698