Chromium Code Reviews
DescriptionReland of Fix initialization ordering in GLES2CmdDecoder. (patchset #1 id:1 of https://codereview.chromium.org/2126183002/ )
Reason for revert:
This patch was probably innocent, https://codereview.chromium.org/2112783002/ was probably guilty.
Original issue's description:
> Revert of Fix initialization ordering in GLES2CmdDecoder. (patchset #2 id:20001 of https://codereview.chromium.org/2105153002/ )
>
> Reason for revert:
> Appears to break GPU webkit tests on Mac and Linux. This revert is a bit speculative since there are like 4 more gpu-related patches in the blame list, but the error messages does mention gles2_cmd_decoder.cc, so picking this patch as the first victim. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/34148/steps/webkit_tests/logs/stdio
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/24915
>
> Original issue's description:
> > Fix initialization ordering in GLES2CmdDecoder.
> >
> > The ContextGroup must be initialized before feature flag checks will work
> > correctly.
> >
> > BUG=602484
> > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/477e47082e76afca7c2e656a0714ee24e67fb702
> > Cr-Commit-Position: refs/heads/master@{#404019}
>
> TBR=piman@chromium.org,erikchen@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=602484
>
> Committed: https://crrev.com/39de5e1f08c3162866e42b8cf932fdef0237c92a
> Cr-Commit-Position: refs/heads/master@{#404112}
TBR=piman@chromium.org,erikchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602484
Committed: https://crrev.com/2e0756e995089857af2491de1a21188d64248fe3
Cr-Commit-Position: refs/heads/master@{#404147}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||