Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2121283002: Reset translation of toolbar_buttons for Url Defocus Animation. (Closed)

Created:
4 years, 5 months ago by PEConn
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer, Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset translation of toolbar_buttons for Url Defocus Animation. The mToolbarButtonsContainer has its translationY modified during scroll so when the user scrolls on the NTP, it appears to scroll too. However during the URL focus and defocus animations it should not be touched. Unfortunately updateNtpTransitionAnimation() is called a few times after the URL focus animation has been completed while mUrlFocusChangeInProgress is set to false, causing translationY to be non-zero at the end. We reset the translationY here so the mToolbarButtonsContainer is on screen for the defocusing animation. BUG=623885 Committed: https://crrev.com/56e3c638ef1575429a2ecd5a19ddd069ba42892b Cr-Commit-Position: refs/heads/master@{#404113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
PEConn
PTAL, the linked bug has before and after videos of the change.
4 years, 5 months ago (2016-07-06 09:36:36 UTC) #3
Bernhard Bauer
LGTM, thanks!
4 years, 5 months ago (2016-07-06 10:08:24 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121283002/1
4 years, 5 months ago (2016-07-06 11:06:20 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-06 11:49:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121283002/1
4 years, 5 months ago (2016-07-07 09:22:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 09:25:42 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 09:25:45 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 09:27:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56e3c638ef1575429a2ecd5a19ddd069ba42892b
Cr-Commit-Position: refs/heads/master@{#404113}

Powered by Google App Engine
This is Rietveld 408576698