Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 2121263002: Prepare for moving V8 compile events to disabled-by-default v8.compile (Closed)

Created:
4 years, 5 months ago by ulan
Modified:
4 years, 5 months ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare for moving V8 compile events to disabled-by-default v8.compile category. This adds v8.compile category to benchmarks that track executionMetric. BUG=625865 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/53450e52ffd2026c1af64b495ebd300069d8ec3e Cr-Commit-Position: refs/heads/master@{#403915}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/perf/benchmarks/v8.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
ulan
Sami, could you please rubber-stamp this one line change?
4 years, 5 months ago (2016-07-06 08:54:39 UTC) #3
Sami
lgtm.
4 years, 5 months ago (2016-07-06 09:57:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2121263002/1
4 years, 5 months ago (2016-07-06 13:02:05 UTC) #6
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-06 13:02:06 UTC) #7
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-06 13:32:11 UTC) #8
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-06 14:01:59 UTC) #9
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-06 14:31:28 UTC) #10
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-06 14:46:01 UTC) #11
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-06 15:01:37 UTC) #12
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-06 15:31:08 UTC) #13
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-06 16:01:23 UTC) #14
commit-bot: I haz the power
There were warnings when CQ was processing your CL: * CQ_EXTRA_TRYBOTS flag is deprecated and ...
4 years, 5 months ago (2016-07-06 16:31:27 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 16:35:20 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 16:37:11 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53450e52ffd2026c1af64b495ebd300069d8ec3e
Cr-Commit-Position: refs/heads/master@{#403915}

Powered by Google App Engine
This is Rietveld 408576698