Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212123005: Quota: Add null check (Closed)

Created:
6 years, 9 months ago by nhiroki
Modified:
6 years, 8 months ago
Reviewers:
kinuko
CC:
blink-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Quota: Add null check StorageQuotaClient can be null in some contexts. BUG=346577 TEST=run the failed test locally (see the issue) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170565

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M Source/modules/quota/DeprecatedStorageQuota.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M Source/modules/quota/StorageQuota.cpp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
nhiroki
Hi kinuko-san, can you review this? Thanks!
6 years, 9 months ago (2014-03-28 12:45:24 UTC) #1
kinuko
On 2014/03/28 12:45:24, nhiroki wrote: > Hi kinuko-san, can you review this? Thanks! The code ...
6 years, 8 months ago (2014-03-31 04:04:42 UTC) #2
nhiroki
On 2014/03/31 04:04:42, kinuko wrote: > On 2014/03/28 12:45:24, nhiroki wrote: > > Hi kinuko-san, ...
6 years, 8 months ago (2014-03-31 13:40:45 UTC) #3
kinuko
ok, lgtm
6 years, 8 months ago (2014-04-01 00:15:53 UTC) #4
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 8 months ago (2014-04-01 00:28:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/212123005/60001
6 years, 8 months ago (2014-04-01 00:28:40 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 01:13:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-01 01:13:57 UTC) #8
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 8 months ago (2014-04-01 01:46:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/212123005/60001
6 years, 8 months ago (2014-04-01 01:47:06 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 02:07:12 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-01 02:07:13 UTC) #12
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 8 months ago (2014-04-01 09:14:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/212123005/60001
6 years, 8 months ago (2014-04-01 09:14:05 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 09:58:04 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-01 09:58:05 UTC) #16
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 8 months ago (2014-04-01 12:55:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/212123005/60001
6 years, 8 months ago (2014-04-01 12:55:11 UTC) #18
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 13:48:16 UTC) #19
Message was sent while issue was closed. 
Change committed as 170565

Powered by Google App Engine
This is Rietveld 408576698