Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 212123002: Unship '::-webkit-distributed(...)' functional pseudo element. (Closed)

Created:
6 years, 9 months ago by hayato
Modified:
6 years, 9 months ago
Reviewers:
esprehn, tasak, dglazkov
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Unship '::-webkit-distributed(...)' functional pseudo element. We've already shipped '::content'. It's time to unship '::-webkit-distributed'. The usage of CSSPseudoElementPrefixedDistributed is '~0%'. http://www.chromestatus.com/metrics/feature/timeline/popularity/99 BUG=268236 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170094

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -851 lines) Patch
M LayoutTests/fast/css/pseudo-escaped-parenthesis.html View 2 chunks +1 line, -2 lines 0 comments Download
M LayoutTests/fast/css/pseudo-escaped-parenthesis-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-css-text.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-css-text-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-dynamic-attribute-change.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-dynamic-attribute-change-expected.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-for-shadow-element.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-for-shadow-element-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-match-all.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-match-all-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-match-descendant.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-match-descendant-expected.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-nested.html View 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-nested-expected.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-no-match.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-no-match-expected.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-relative-selector.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-relative-selector-css-text.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-relative-selector-css-text-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-relative-selector-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-relative-selector-invalid.html View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-relative-selector-invalid-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-reprojection.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-reprojection-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-scoped.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-scoped-expected.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-specifiers-in-left-side.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-specifiers-in-left-side-expected.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-style-in-doc.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-style-in-doc-expected.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-support-selector.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-support-selector-expected.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-used-in-selector-list.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-used-in-selector-list-expected.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-with-any.html View 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/fast/dom/shadow/distributed-pseudo-element-with-any-expected.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-pseudo-distributed.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-pseudo-distributed-expected.html View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/css/CSSGrammar.y View 1 3 chunks +0 lines, -22 lines 0 comments Download
M Source/core/css/CSSParserValues.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/css/CSSParserValues.cpp View 1 2 chunks +0 lines, -12 lines 0 comments Download
M Source/core/css/CSSSelector.h View 1 3 chunks +0 lines, -12 lines 1 comment Download
M Source/core/css/CSSSelector.cpp View 1 4 chunks +0 lines, -7 lines 0 comments Download
M Source/core/css/CSSTokenizer-in.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 3 chunks +0 lines, -37 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hayato
PTAL
6 years, 9 months ago (2014-03-26 06:16:23 UTC) #1
hayato
https://codereview.chromium.org/212123002/diff/2/Source/core/css/CSSSelector.h File Source/core/css/CSSSelector.h (left): https://codereview.chromium.org/212123002/diff/2/Source/core/css/CSSSelector.h#oldcode224 Source/core/css/CSSSelector.h:224: enum OptionalPseudoTypeRequirements { Note: This should have been removed ...
6 years, 9 months ago (2014-03-26 06:59:15 UTC) #2
dglazkov
lgtm
6 years, 9 months ago (2014-03-26 16:23:02 UTC) #3
esprehn
lgtm
6 years, 9 months ago (2014-03-26 20:03:27 UTC) #4
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-26 20:03:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/212123002/2
6 years, 9 months ago (2014-03-26 20:04:13 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 20:35:59 UTC) #7
Message was sent while issue was closed.
Change committed as 170094

Powered by Google App Engine
This is Rietveld 408576698