content/renderer/media/audio_device_factory.cc - Issue 2121223002: AudioOutputDevice authorization timeout UMA histograms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/audio_device_factory.cc

Issue 2121223002: AudioOutputDevice authorization timeout UMA histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: timeout set to 2000, UMA stat added. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/audio_device_factory.cc

diff --git a/content/renderer/media/audio_device_factory.cc b/content/renderer/media/audio_device_factory.cc

index a776d694ef60d3f1a579f4b48c09456a19785236..fd8dace9d9a2a5e4893b328effb06176bf71de15 100644

--- a/content/renderer/media/audio_device_factory.cc

+++ b/content/renderer/media/audio_device_factory.cc

@@ -31,7 +31,7 @@ namespace {

// chance device authorization response is never received from the browser side.

// In this case we will time out, to avoid renderer hang forever waiting for

// device authorization (http://crbug/615589). This will result in "no audio".

-const int64_t kMaxAuthorizationTimeoutMs = 900;

+const int64_t kMaxAuthorizationTimeoutMs = 2000;

#else

const int64_t kMaxAuthorizationTimeoutMs = 0; // No timeout.

#endif // defined(OS_WIN)

« no previous file with comments | « no previous file | media/audio/audio_output_device.h » ('j') | media/audio/audio_output_device.cc » ('J')